If `compose` is used with `prepare`, main handler never called

[lukeed]

If `compose` is used with `prepare`, main handler never called

[leaysgur]

I prefer Option 3 or 4, for its context is explicit.
But a1ab931 also looks good to me. Since this issue can be handled internally.

Anyway, thank you for quick fix! 🙌🏻

[lukeed]

Ahhh you're right, this is a bug 🙈

I'll put in a temporary fix for now, but this is going to have to be reworked.
What do you think about these options? It'd be for prepare only:

// Option 1:
// Use `true` flag for `prepare` usage
// PRO: Not breaking. Same `compose` utility
// CON: Built-in secondary usage (kinda weird)

API.prepare = compose(
  true, // isPrepare
  CORS.preflight,
  // ... others
);

// no change for route handlers
API.add('GET', '/demo', compose(foo, bar));


// Option 2:
// Change `compose` to (handlers: Handler[], isPrepare?: boolean) signature
// PRO: Clear, single method signature
// CON: Breaking & I find it kinda ugly, lol 

API.prepare = compose([
  CORS.preflight,
  // ... others
], true); //< here

// route handler
API.add('GET', '/demo', compose([foo, bar]));


// Option 3:
// Add new `group` utility *only* for prepare usage
// PRO: Not breaking
// CON: Choosing between group vs compose may be confusing

API.prepare = group(
  CORS.preflight,
  // ... others
)

// no changes to route handlers
API.add('GET', '/demo', compose(foo, bar));


// Option 4:
// Make `prepare` accept Array of handler
// PRO: Not breaking, no `compose` confusion
// CON: Doesn't feel very nice (personal?)

API.prepare = [
  CORS.preflight,
  // ... others
]

// no changes to route handlers
API.add('GET', '/demo', compose(foo, bar));

[lukeed]

I actually did this in a way that should be fine when subrouters (#29) land too.
It's not super-duper ideal, but it works 😅

[lukeed]

Thanks for the feedback (and the report!)

It might not need to change at all going forward, luckily.