[Feature Request] Random quote by specific author

[lein1013]

[Feature Request] Random quote by specific author

[raxraj]

@lukePeavey,
First of all, I like this so much, I use it almost every time that I could.
Is this still open? I am up for this.

[raxraj]

@lukePeavey @lein1013 , Awesome,
I'll get right on it.

[lukePeavey]

If you would like to submit a PR for this, please feel free. If not, I can do it next weekend.

quotable/src/controllers/quotes/randomQuote.js

Lines 12 to 14 in 7e85472

	const { minLength, maxLength, tags } = req.query
	const filter = {}

Add additional params

-const { minLength, maxLength, tags } = req.query
+const { minLength, maxLength, tags, author, authorId } = req.query

Add the filters for author and/or authorId

if (authorId) {
  filter.authorId = { $in: authorId.split('|') }
}

if (author) {
  filter.author = { $in: author.split('|') }
}

[lukePeavey]

That's a good idea. We can definitely do that

[lukePeavey]

One thought....

The tags param takes a comma separated list, which translates to an AND query (with "tag-one" AND "tag-two"), or a | separated list, which translates to an OR query (with "tag-one" OR "tag-two").

For consistency, would it make sense for this param to take a | separated list since its an OR query (by "author-one" OR "author-two").

Let me know what you think.

[lein1013]

Nothing done from my side, but I would be happy to see this feature soon :-)

[lukePeavey]

@raxraj did you want to work on this? If so it's all yours