Giter Site home page Giter Site logo

Comments (12)

safetypins avatar safetypins commented on May 25, 2024 2

I hope this is helpful, and thanks for all the work you've done to put this together.

from drupal9ci.

safetypins avatar safetypins commented on May 25, 2024 1

Thanks so much, that worked! On to the next error.

from drupal9ci.

fjgarlin avatar fjgarlin commented on May 25, 2024 1

I updated the readme file linking to your comment above @safetypins and the symlink trick. Thanks for reporting the issue and for following up with the affected files.

from drupal9ci.

juampynr avatar juampynr commented on May 25, 2024

Hi @safetypins, I think that there is a symlink that should take care of that already. Did this happen on an update or on a fresh installation of drupal9ci?

cc @m4olivei and @fjgarlin in case it rings a bell.

from drupal9ci.

fjgarlin avatar fjgarlin commented on May 25, 2024

Yeah Drupal should be in the right Apache folder. Did you change anything from the default files? Which of the tasks fail? Perhaps a link to the task or further output might help.

from drupal9ci.

safetypins avatar safetypins commented on May 25, 2024

it's a fresh installation of drupal9ci in an established drupal installation. I've changed a few things in the default d9ci config files, but only to get rid of errors that I've encountered before this, like figuring out how to get drush running, giving drush the correct web root, pulling over a database dump. Mostly I've replaced /web/ with /docroot/.

Not everything is broken, the coding standards tests were running properly before I turned them off. I've disabled everything but the behat testing, because that's the sort of testing I'm primarily interested in. As far as I know, I've not made any changes related to apache configuration; I can't even find any references to apache configuration. When I searched google for this, most of the suggestions involved an circleci.conf file that needed to be updated, but this project doesn't include that, does it?

from drupal9ci.

safetypins avatar safetypins commented on May 25, 2024

Ok, I'm just realizing you were asking for a link to the circleci task, so here you go: https://app.circleci.com/pipelines/github/RhodesCollege/rhodes_edu/191/workflows/ad9c9fb6-74db-41e2-b7cf-a6a86aa72d2e/jobs/240

from drupal9ci.

fjgarlin avatar fjgarlin commented on May 25, 2024

Ok, it’s definitely the web to docroot change then. The easiest would be to symlink one to the other in the robofile, like here: https://github.com/Lullabot/drupal9ci/blob/master/dist/bitbucket/RoboFile.php#L187 (you’ll need to adapt paths).

Otherwise if you change docroot to web at Drupal level things should just work.

from drupal9ci.

fjgarlin avatar fjgarlin commented on May 25, 2024

Great! Any sort of feedback at the end would be appreciated and perhaps we can update docs.

from drupal9ci.

juampynr avatar juampynr commented on May 25, 2024

thanks for the help @fjgarlin !

from drupal9ci.

safetypins avatar safetypins commented on May 25, 2024

Sure. I have found this whole process pretty confusing, although it's less confusing than my first attempt a few months ago. I don't know how common it is for people to change the web directory to something else, but it definitely would have helped to have a list of the places where this change impacts the configuration. Let me see if I can compile a list of changes I made.

from drupal9ci.

safetypins avatar safetypins commented on May 25, 2024

So, thinking back on the process so far, I felt like there were a bunch of different places where I had to change web to docroot. I'm not sure why, but for some reason when I was first searching for where to change this, I searched for "web/" instead of just "web". This missed several references, which I have found now when I tried to go through the process. I think this was really just an error on my part. But here's a list of files & lines that I've changed:

RoboFile.php

Lines 118-119

$tasks[] = $this->taskFilesystemStack()
    ->copy('.circleci/config/settings.local.php', 'web/sites/default/settings.local.php', $force);

Lines 227-228

$tasks[] = $this->taskFilesystemStack()
    ->copy('.circleci/config/phpunit.xml', 'web/core/phpunit.xml', $force)

Line 231

->exec('../vendor/bin/phpunit -c core --debug --verbose --log-junit ../artifacts/phpunit/phpunit.xml modules/custom');

Lines 269-272

$tasks[] = $this->taskExecStack()
    ->exec('vendor/bin/phpcs --standard=Drupal --report=junit --report-junit=artifacts/phpcs/phpcs.xml web/modules/custom')
    ->exec('vendor/bin/phpcs --standard=DrupalPractice --report=junit --report-junit=artifacts/phpcs/phpcs.xml web/modules/custom');

Line 284

$docroot = $this->getDocroot() . '/web';

config/phpunit.xml

Line 30

<env name="BROWSERTEST_OUTPUT_DIRECTORY" value="/opt/drupal/web/sites/simpletest"/>

config/behat.yml

Line 19

drupal_root: '/opt/drupal/docroot'

In addition to these changes, I found that the Drush executable was not found. So I had to add a command to run composer install.

In circleci.yml, line 37 I inserted:

- run:
    name: Install dependencies
    command: composer install

I'm not sure if I did this preemptively or in response to an error, but after I got the dump.sql file downloaded into the container, I added the full path to the db dump.sql file (/opt/drupal/dump.sql) to the drush sql-cli command.

from drupal9ci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.