Giter Site home page Giter Site logo

Comments (8)

pureooze avatar pureooze commented on May 11, 2024 1

I messed around with Fuse a bit and it seems like this cant be changed by just modifying the threshold or distance settings. When I modify those the desired result just disappears from the results altogether. I was able to get better results when enabling 'Tokenize' and 'Match all tokens'. I'll look more into this and update how saka does Fuzzy search if I find this makes more sense for users.

from saka.

pureooze avatar pureooze commented on May 11, 2024

Hi @orschiro thanks for making an issue. I just tried using the great suspender extension and suspending http://radio.abc.net.au/ manually by going to the tab and clicking suspend in the extension menu. It seems to work fine for me, I see an entry in Saka for the suspended tab.

image

I thought the issue might be that you were relying on the auto suspend feature so the tab wasnt getting picked up but when I try using the "suspend other tabs" feature, the tabs I had open are still visible in the saka search.

Could you provide step by step instructions on how to reliably reproduce this?

from saka.

orschiro avatar orschiro commented on May 11, 2024

from saka.

pureooze avatar pureooze commented on May 11, 2024

Isn't the last result in that image the tab you were looking for? When I follow the steps you mentioned, the tab shows up as a result at the very bottom of page 1 for me. If that is the case I think the issue with the missing result may just have to do with the Fuse.js threshold being too strict.

from saka.

orschiro avatar orschiro commented on May 11, 2024

from saka.

orschiro avatar orschiro commented on May 11, 2024

@pureooze I appreciate your further tests and I remain confident that you will find a solution that benefits all users equally. Appreciated!

from saka.

pureooze avatar pureooze commented on May 11, 2024

@orschiro I think I have got this fixed by just increasing the distance that Fuse uses when performing a search so it doesn't punish titles/urls that are longer than their peers.

image

PR coming soon.

from saka.

orschiro avatar orschiro commented on May 11, 2024

@pureooze thanks so much for your work on this issue!

This is looking very good. :-)

from saka.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.