Giter Site home page Giter Site logo

Comments (6)

renanpvaz avatar renanpvaz commented on September 27, 2024

Hey there, I think I could work on this.

from herms.

langston-barrett avatar langston-barrett commented on September 27, 2024

@renanpvaz That sounds wonderful! Please comment here or email me if any questions come up. As you begin coding, you may want to take a look at #76, which makes some significant changes and should be merged soon(ish) (to be sure we don't end up with conflicting changes).

from herms.

dreamsmasher avatar dreamsmasher commented on September 27, 2024

Early implementation in #123. However, colorization and bolding still need to be added, as well as support for multiple regular expressions at once.

Should we bold the titles of the matching recipes? Or the string matches?

from herms.

langston-barrett avatar langston-barrett commented on September 27, 2024

as well as support for multiple regular expressions at once

What would be the advantage of multiple regexes (rx1 and rx2) vs. a regex union like (rx1|rx2)?

Should we bold the titles of the matching recipes? Or the string matches?

I'd say the string matches, but that's just personal preference. I'm not too picky as long as it looks good!

from herms.

dreamsmasher avatar dreamsmasher commented on September 27, 2024

I think it's more user friendly to be able to specify multiple regexes in sequence, but if a user actually uses regex features instead of just strings, I figure they would know how to use unions as well. Just a thought.

I'll take a look into colorizing the string match output when I get a chance, really busy week :(

from herms.

langston-barrett avatar langston-barrett commented on September 27, 2024

I think it's more user friendly to be able to specify multiple regexes in sequence, but if a user actually uses regex features instead of just strings, I figure they would know how to use unions as well. Just a thought.

Fair enough, that's basically what I expected but wanted to be sure I wasn't missing anything. I'm happy either way (if we have support for multiple regexes or not).

I'll take a look into colorizing the string match output when I get a chance, really busy week :(

Sure thing, no need to hold up a nice new feature with window dressing.

from herms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.