[BUG] Can't compile on windows : error related to libnop

[masterchef8]

[BUG] Can't compile on windows : error related to libnop

[SClerckx]

Replicated this issue and solved on this setup: Windows 11, Visual Studio 22, MSVC 14.37 CXX 14 and 17 Standard.

encoding.h and logical_buffer.h are from libnop. The compile error occurs if #include<windows.h> is declared before #include <depthai/depthai.hpp>. The ::min() and ::max() from windows.h conflict with those present in libnop. This might also happen if other dependencies include widows.h on their end.

The fast workaround is to include depthai before windows.h, or #define NOMINMAX before including widows.h.

My compile errors when the issue is present:

encoding.h(475): error C2589: '(': illegal token on right side of '::'
encoding.h(475): error C2062: type 'unknown-type' unexpected
encoding.h(475): error C2589: '(': illegal token on right side of '::'
encoding.h(475): error C2059: syntax error: ')'
encoding.h(475): error C2059: syntax error: ')'
encoding.h(477): error C2181: illegal else without matching if
encoding.h(618): error C2589: '(': illegal token on right side of '::'
encoding.h(618): error C2062: type 'unknown-type' unexpected
encoding.h(618): error C2589: '(': illegal token on right side of '::'
encoding.h(618): error C2059: syntax error: ')'
encoding.h(618): error C2059: syntax error: ')'
encoding.h(620): error C2181: illegal else without matching if
encoding.h(620): error C2589: '(': illegal token on right side of '::'
encoding.h(620): error C2062: type 'unknown-type' unexpected
encoding.h(620): error C2589: '(': illegal token on right side of '::'
encoding.h(620): error C2059: syntax error: ')'
encoding.h(620): error C2059: syntax error: ')'
encoding.h(622): error C2181: illegal else without matching if
encoding.h(781): error C2589: '(': illegal token on right side of '::'
encoding.h(781): error C2062: type 'unknown-type' unexpected
encoding.h(781): error C2589: '(': illegal token on right side of '::'
encoding.h(781): error C2059: syntax error: ')'
encoding.h(781): error C2059: syntax error: ')'
encoding.h(783): error C2181: illegal else without matching if
encoding.h(783): error C2589: '(': illegal token on right side of '::'
encoding.h(783): error C2062: type 'unknown-type' unexpected
encoding.h(783): error C2589: '(': illegal token on right side of '::'
encoding.h(783): error C2059: syntax error: ')'
encoding.h(783): error C2059: syntax error: ')'
encoding.h(785): error C2181: illegal else without matching if
encoding.h(785): error C2589: '(': illegal token on right side of '::'
encoding.h(785): error C2062: type 'unknown-type' unexpected
encoding.h(785): error C2589: '(': illegal token on right side of '::'
encoding.h(785): error C2059: syntax error: ')'
encoding.h(785): error C2059: syntax error: ')'
encoding.h(787): error C2181: illegal else without matching if
logical_buffer.h(62): error C2589: '(': illegal token on right side of '::'
logical_buffer.h(62): error C2059: syntax error: ')'
logical_buffer.h(62): error C2334: unexpected token(s) preceding ':'; skipping apparent function body
logical_buffer.h(65): error C2143: syntax error: missing ')' before ';'
logical_buffer.h(65): error C2059: syntax error: ')'
logical_buffer.h(65): error C2238: unexpected token(s) preceding ';'
logical_buffer.h(65): fatal error C1201: unable to continue after syntax error in class template definition