Comments (2)
I Found the reason.
the version returned by version.Minor is 9+. When doing a
strconv.Atoi(version.Minor)the version is 0 and then uses the old version.
i tried to add a branch, but i´m not able to create branches. One possible fix is to regex the version number:
....
oldVersion := false
major, _ := strconv.Atoi(version.Major)
re := regexp.MustCompile("[0-9]+")
minor, _ := strconv.Atoi(re.FindAllString(version.Minor, -1)[0])
if major < 2 && minor < 8 {
oldVersion = true
}
...
it´s working then with current gcp kubernetes clusters.
from kube-cleanup-operator.
That is very weird. If I'm not mistaken that breaks the SemVer convention.
Thank you for reporting the issue and creating the PR
from kube-cleanup-operator.
Related Issues (20)
- Multi namespace HOT 3
- problem using flags HOT 1
- helm chart HOT 9
- be able to configure operator to remove only jobs HOT 2
- be able to specify different successful/failed ttl for each pod/job HOT 2
- log the status of a job/pod being removed HOT 1
- move docker images away from docker HOT 2
- Replace travis-ci with github-actions
- ignore namespaces HOT 2
- Add more consistency to command line flags
- Add support for annotation-based customizations HOT 2
- Request for deleting pods stuck terminating HOT 1
- Problems running helm HOT 1
- helmchart not work HOT 2
- can't install helm chart by using absolute URL HOT 1
- Need support for priorityClass and containerSecurityContext HOT 2
- Pulling from helm chart kube-cleanup-operator-1.0.3.tgz file not found HOT 2
- PR Submission HOT 3
- Errors after helm install, "Failed to list *v1.Pod: pods is forbidden" HOT 4
- fix CVE-2023-39325: Update package golang.org/x/net to the 0.17.0 version HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kube-cleanup-operator.