Giter Site home page Giter Site logo

Comments (2)

SqiSch avatar SqiSch commented on July 18, 2024

I Found the reason.
the version returned by version.Minor is 9+. When doing a
strconv.Atoi(version.Minor)the version is 0 and then uses the old version.

i tried to add a branch, but i´m not able to create branches. One possible fix is to regex the version number:

....
	oldVersion := false

	major, _ := strconv.Atoi(version.Major)
	re := regexp.MustCompile("[0-9]+")
	minor, _ := strconv.Atoi(re.FindAllString(version.Minor, -1)[0])

	if major < 2 && minor < 8 {
		oldVersion = true
	}
...

it´s working then with current gcp kubernetes clusters.

from kube-cleanup-operator.

lwolf avatar lwolf commented on July 18, 2024

That is very weird. If I'm not mistaken that breaks the SemVer convention.
Thank you for reporting the issue and creating the PR

from kube-cleanup-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.