Date & Time widget typo on right click

[sirlark]

Date & Time widget typo on right click

[jleclanche]

To be fair, it's Date AND Time, not Date bitwise-and Time.

[sirlark]

Haha. Fair point! Still the common usage in written English would be single ampersand

[jleclanche]

Are you running latest lxqt panel and qt5? Im not seeing this issue.

[paulolieuthier]

Yes, let's fix it.

How should it be?

[paulolieuthier]

That patch fixes it. Weird line, that one. What was the point?

diff --git a/panel/lxqtpanel.cpp b/panel/lxqtpanel.cpp
index 671697a..f3c3d55 100644
--- a/panel/lxqtpanel.cpp
+++ b/panel/lxqtpanel.cpp
@@ -869,7 +869,7 @@ void LxQtPanel::showPopupMenu(Plugin *plugin)

         if (m)
         {
-            menu.addTitle(plugin->windowTitle().replace("&", "&&"));
+            menu.addTitle(plugin->windowTitle());

             menu.addActions(m->actions());
             pluginsMenus << m;

[jleclanche]

@paulolieuthier It's possible the & character needs escaping. Make sure your patch works in both Qt4 and Qt5. I for one cannot reproduce the issue.

[paulolieuthier]

I will look further into that.

[paulolieuthier]

No problem in Qt4. It's just a string, right?

[paulolieuthier]

@sirlark could you please test the PR?

[sirlark]

Sorry, PR? What is the PR?

[paulolieuthier]

Pull request: #88.

[sirlark]

Right! Of course. Sure thing, I'll do it tonight, I'm at work at the moment.

[paulolieuthier]

Merged.