.kill() not executing properly on window resize [bug]

[lyfeyaj]

.kill() not executing properly on window resize [bug]

[loup-brun]

Great! So the only thing left is feedback from @AlexanderYW to make sure the issue has been resolved.

[loup-brun]

Could you be more specific about the inline styling you find should be removed?

Regarding your piece of code, you should call the setup function rather than instantiating Swipe on every resize event.

$(window).on('resize', function() {
  if($(window).width() < 800) {
    window.mySwipe.setup();
  } else {
    window.mySwipe.kill()
  }
});

I am creating a fix to remove the cloned slides on kill (special case for 2 slides).

[loup-brun]

There is an issue when only using the setup method: some events are not registered inside that function. Will look into it during the fix.

[AlexanderYW]

Its the inline styling on the swipe views/"pages" (.swipe -> .swipe-warp -> div <- this)

Regarding the .setup() your right, i forgot about that one, thanks!

When are your fix going live?, not sure if the NPM is updating from Github or you have to tell it to, because I'm using the one from there :)

[AlexanderYW]

About the issue with .setup(), same goes for when you are using swipe through jquery "$('#swipe').Swipe()", callback does not trigger i think it was

[loup-brun]

The issue should now be fixed, see the latest release (2.0.12).

Summary:

• Inline styles applied by Swipe (transition, transition-duration, etc.) are now removed.
• Event handlers are bound during the setup (and not only when calling a new Swipe instance).
• Cloned slides for 2-slide scenario are tagged and removed on kill to avoid confusion with original ones.

Let me know if you still have some issues!

[loup-brun]

As for the other repositories, such as NPM and Bower… I guess @lyfeyaj has to push the changes there?

[lyfeyaj]

@loup-brun @AlexanderYW

Version 2.0.12 has been pushed to npm registry.
Bower will be updated automatically after bower.json changed.

[AlexanderYW]

Awesome job guys, it works like a charm now!

I'm closing this one, since the problem is solved