Comments (2)
That's an interesting question. When I wrote the API, I hesitated between going with an int or a long whose 32 lower bits would be used, but preferred the int version as it made very clear that this hash function only works on 32 bits.
I would like to have more opinions on this one, if there seems to be consensus around moving to a long whose 32 lower bits would be used, I would be happy to change it.
Note to readers of this issue: You can turn the hash to an unsigned value by applying a mask, ie. StreamingXXHash32.getValue() & 0xFFFFFFFFL
which will turn the integer value into an unsigned long.
from lz4-java.
I think it depends on the supporting a 'realistic use-case' -- if what @meden describes is absolutely a valid and potentially common use-case, then the API should probably support without the need to resort to bit ops.
If it's more of an edge case and not how the API was meant to be used or not in the spirit of it, then probably just great javadoc to clarify the bit ops approach.
My 2 cents and my eternal belief in the 'path of least surprise' when it comes to API design :)
from lz4-java.
Related Issues (20)
- Premature end of data while decompressing HOT 3
- CVE-2021-3520 Whether the vulnerability affects LZ4-Java HOT 2
- why lz aarch64 version is 1.9.1
- How to decopress large LZ4 files? HOT 1
- the value don't equal xxhsum,the value length is 15 HOT 2
- how to build 'arm64/liblz4-java.so' ? HOT 1
- Data larger than 4194304 Bytes is not decompressed correctly HOT 2
- lz4 legacy format support (typically for Linux Kernel compression) HOT 1
- LZ4 java with double buffering
- LZ4 decompression exception Malformed input at
- Exception in thread "main" net.jpountz.lz4.LZ4Exception: Malformed input at 16 HOT 3
- Add riscv support
- Stream ended prematurely when trying to readAllBytes
- Compile with frame pointers?
- Another release? HOT 5
- Enable support for riscv64 HOT 1
- JVM crashes at insertAndFindBestMatch
- Add more maintainers to `lz4-java` repo HOT 1
- add option to prefer java version when a library is hardcoded to LZ4Factory.fastestInstance
- Include generated source files in sources JAR deployed to Maven Central
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lz4-java.