Unavoidable GOTO

[m0rf30]

Unavoidable GOTO

[zamber]

That's right.

https://github.com/M0Rf30/android-udev-rules/blob/master/51-android.rules#L496 :

# Skip other vendor tests
LABEL="android_usb_rule_match"

How exactly is that an issue for you, @tibocapo?
Once you get a matching vendor ID, there's no point in parsing anything after that.

[tibocapo]

My issue is my vendor id is never matched because of this row:

https://github.com/M0Rf30/android-udev-rules/blob/master/51-android.rules#L132

I have an HTC which is supposed to be check after this GOTO.

[zamber]

I see, this should be fixed. I'll do a Pull request later today if I find a free minute. For now just change it from:

#   Honeywell/Foxconn
ATTR{idVendor}=="0c2e", ENV{adb_user}="yes"
#       D70e
ATTR{idProduct}=="0ba3", SYMLINK+="android_adb"
GOTO="android_usb_rule_match"

to:

#   Honeywell/Foxconn
ATTR{idVendor}!="0c2e", GOTO="not_Foxconn"
ENV{adb_user}="yes"
#       D70e
ATTR{idProduct}=="0ba3", SYMLINK+="android_adb"
GOTO="android_usb_rule_match"
LABEL="not_Foxconn"

and it should work fine.

[tibocapo]

Thanks

[zamber]

You're welcome :). Thanks for taking your time to get an account on GitHub
to report this!

On Wed, Oct 12, 2016 at 4:20 PM tibocapo [email protected] wrote:

Thanks

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#88 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiACkpW-252gSD2aki3pg3Y5ytzFC1Hks5qzK6kgaJpZM4KTsPZ
.