Giter Site home page Giter Site logo

Comments (5)

GoogleCodeExporter avatar GoogleCodeExporter commented on July 19, 2024
This is because the class above is declared "package-private". "package-private"
means neither "private", nor "public", nor "protected" modifier is used. 
ModifierSet
can only check if a modifier was actually used in the parsed code.

Original comment by [email protected] on 15 Jan 2010 at 10:06

from javaparser.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 19, 2024
Thanks michaelkoch6.
It seems rodrigo had a little mistake. Am I right?
I will close this issue until this mistake be demystified.

Original comment by [email protected] on 15 Jan 2010 at 3:14

  • Changed state: Invalid

from javaparser.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 19, 2024
Hi,
i think it should be useful to have that "package private" modifier in the 
parser.
i'm making a diff. tool and out of the box i can't know if the modifier has 
changed 
from package private to just private (or other).
To solve the issue i had to implement a exhaustive if (if it's not private, not 
public, etc. then it should be package private). It's not a very clean 
solution, it 
would be nicer if the parser could answer "ModifierSet.isPackagePrivate(...)".
Just my opinion ;)

Original comment by [email protected] on 15 Jan 2010 at 3:22

from javaparser.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 19, 2024
package private means the lack of modifiers. This is why there is no flag for 
this.
If the method "ModifierSet.isPackagePrivate(...)" existed, it's implementation 
should
be composed by the same ifs you've done in your code. 

I agree with you that in some situations it could be useful. But it shouldn't be
implemented in the class "ModifierSet". Maybe in a helper class.

Original comment by [email protected] on 15 Jan 2010 at 3:31

from javaparser.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 19, 2024
Well, maybe a method "hasModifiers()" or something like that make more sence, i 
see 
the point for not having a package private modifier (as modifiers do that, 
explicitly change the default package private behavior). 

Original comment by [email protected] on 15 Jan 2010 at 3:43

from javaparser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.