Reoccurring damage from synergy effects

[maael]

Reoccurring damage from synergy effects

[maael]

Hey, thanks for the comment!

At the moment the technique synergy info is a bit hit and miss for sure, there's a comment here outlining most of the cases I haven't taken care of yet. I'll try to get it fixed ASAP!

[ToddGeorgeKelly]

I apologize that I didn't see that beforehand. I will keep an eye out for anything else I run into! Thanks so much!

( I do hope that I do not come off as critical haha. Your API has been crazy helpful to me. I wanted to make an app just for fun and your data is the best source out there rn. )

[maael]

@ToddGeorgeKelly Not critical at all, it's useful for me to get other peoples feedback, thanks for taking the time to use the API and let me know your thoughts.

Just as a heads up - this has now been resolved, and technique synergy information is much more uniform, and actual contains all the information now.

The change is that the SynergyEffect and SynergyDamage fields have been removed from techniques.

Now instead, there is the SynergyEffects key, which contains an array of objects of the following shape:

{
  "effect": "Effect description",
  "type": "damage",
  "damage": 0
}

The current possible values for type are:

Type
damage
buff
debuff
condition
priority
unknown

damage will be 0 for anything not of damage type.

Hopefully that all makes sense, and seems like a good solution. Let me know what you think! I'm going to close this for now as I think this should resolve it, but if it doesn't, feel free to reopen the issue.