Not bundling the composer file fails on some dependencies

[macfja]

Not bundling the composer file fails on some dependencies

[MacFJA]

The only reason that I remove composer.json (and lock) is to remove useless files.

I assumed that no third-party code will need its composer.json, but you prove me that it's not the case 😄

Feel free to open a PR to remove this line.

[theofidry]

@MacFJA and on another hand for some tools like PHP-CS-Fixer where compression is disabled they should by all means be excluded along with some unneeded composer related files :/

[MacFJA]

@theofidry If dependencies are managed correctly (for example php-cs-fixer is set as dev requirement), PharBuilder can exclude all dev dependencies (which is the case by default).

[theofidry]

@MacFJA I meant PHP-CS-Fixer as the tool itself for its own PHAR, not as a dep. Their PHAR is not compressed, so excluding files like composer.json, composer.lock, installed.json which are not necessary for the PHAR to run should be excluded otherwise the PHAR size can quickly go up

[PeeHaa]

@theofidry Can you confirm my test results in the PR and verify it's not a concern please?

[PeeHaa]

Also does php-cs-fixer even use this project to build there phar? @theofidry

As far as I can see they are using box

[theofidry]

I'm just sharing this information in case this might be a concern, not to say the composer.json should be included or excluded.