Giter Site home page Giter Site logo

Comments (6)

bt2901 avatar bt2901 commented on June 22, 2024 1

I think you are moving the goalposts. We do not provide guarantees on _fit, but it does not forbid the user to use it. Making this method a bit more flexible does not change that.

Also, training a model without Cubes + Experiment overhead is exactly why one would consider using the method (e.g. for very dirty prototyping or perhaps for cases not covered by Cubes + Experiment yet).

from topicnet.

Alvant avatar Alvant commented on June 22, 2024

off-topic (although not quite): BaseModel has TODO in _fit's docstring for dataset_trainable
base_fit

from topicnet.

bt2901 avatar bt2901 commented on June 22, 2024

Did you mean Union instead of Tuple? Or am I confused about OR operator in typing?

from topicnet.

Alvant avatar Alvant commented on June 22, 2024

Exactly! The owls are not what they seem. Corrected!

from topicnet.

Evgeny-Egorov-Projects avatar Evgeny-Egorov-Projects commented on June 22, 2024

First, _fit is "protected" method, meaning we do not guarantee that it should work nice and easy for the user and that everything will work. Meaning, that normally user should not use it to train a model and it exists so we can hook up library components with this method.

Given that we go forward and implement this enhancement we will have to change some of the core architecture: making method "legal" to use makes it so that we have to 1) add a cube information to the fit 2) check that the fit is not overlapping with previous actions 3) train model in a separate thread and save/load it afterwards...

See where it's going? the nice and simple method grows into something that duplicates existing functionality and puts it into the "models" class that we already wanted to "separate" from the training action.

from topicnet.

Alvant avatar Alvant commented on June 22, 2024

First, _fit is "protected" method, meaning we do not guarantee that it should work nice and easy for the user and that everything will work

Ok, but it doesn't mean that we shouldn't think about how to make the method better 🙂

from topicnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.