Comments (8)
from ixwebsocket.
I'll take a look when I have time but if you have an idea for a fix please go ahead :)
from ixwebsocket.
ps: I should say that I am not positive that it is a regression, but it is still a bug.
from ixwebsocket.
I had a look and created a PR to fix this, but in fact this was nothing to do with the 935e679
- First, when we receive the close code / reason remotely, the reason had 2 characters more than it needed (that why we could see "ac" or "%" or whatever randomnly read from memory)
- Second, when we used the close() method, we sent the code but not the reason, so we can't expect to read it on the other side
- Not directly linked, but we can call the
_onCloseCallback(_closeCode, _closeReason, _closeWireSize);
with not really initialized value (0, "", 0) in the case we callsetReadyState(CLOSED)
outside theclose()
method
All of this should be fixed in PR #34
from ixwebsocket.
So is the issue fixed as you wanted with last PR?
from ixwebsocket.
make ws_test
seems to behave now !
from ixwebsocket.
I think that the next step here is to add the ability to specify a reason and a code when calling websocket.close, but that might be very easy.
from ixwebsocket.
Just 2 parameters to add; you can if you want to :)
from ixwebsocket.
Related Issues (20)
- Allow to bind after construction of `ix::WebSocketServer` and `ix::HttpServer` HOT 1
- Need a way to identify the clients of a WebsocketServer HOT 1
- How to build project that includes IXWebSocket without using vcpkg HOT 1
- the client did not receive the close event HOT 3
- Cannot link against IXWebsocket HOT 1
- HTTPServer questions? HOT 2
- Question about weak_ptr in API HOT 1
- Source code release v11.4.4 contains an error in IXSocketMbedTLS.cpp line 52 HOT 3
- Can I use IXHttpClient to upload files to server? HOT 1
- each http request cause socket reconnection HOT 1
- [BUG] Does not receive a close or error message. and the mapping configured in the host file does not take effect
- Memory leak in proxy code HOT 4
- Universal Windows application TLS certificate issue HOT 2
- UWP App undefined method PathMatchSpecA HOT 2
- Client connection closed immediately on re-connection after ping timeout HOT 1
- Disable ZLIB when install as vcpkg package? HOT 1
- Build error. (mbedtls) HOT 2
- [Feature Request] Add support for OpenSSL SSLKEYLOGFILE HOT 9
- Unable to connect to ws endpoint behind standard AWS load balancer (ALB) HOT 8
- CMake packaging doesn't support example usage HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ixwebsocket.