Ping unittests are broken on the master branch

[machinezone]

Ping unittests are broken on the master branch

[bsergean]

I think that the second one might still be broken, and it will fail randomly. That one.

/Users/travis/build/machinezone/IXWebSocket/test/IXWebSocketPingTest.cpp:473: FAILED:
REQUIRE( serverReceivedPingMessages == 2 )
with expansion:
3 == 2
https://travis-ci.com/machinezone/IXWebSocket/jobs/199446279

[bsergean]

Just pushed something to make all derived classes use 'final' keyword.

Hope it helps, it is recommended here for the 'vptr' kindof error.
https://github.com/google/sanitizers/wiki/ThreadSanitizerPopularDataRaces

[Dimon4eg]

It seems now it's fixed!

[Dimon4eg]

Still fails:

/Users/travis/build/machinezone/IXWebSocket/test/IXWebSocketPingTimeoutTest.cpp:368: FAILED:
  REQUIRE( webSocketClient.isClosed() == true )
with expansion:
  false == true

[bsergean]

FYI I have disabled the 2 Ping related unittest, which isn't good, but better than super flaky unittest. It still fails somewhat randomly at times, but looks more stable now.

I've made a server change for the best I hope.

[AlexandreK38]

What do we have to do then? We are not sure about the CI or the code

[bsergean]

I'm not too sure either. Here are some random thoughts:

We could have a branch / or PR where we tweak things until something gets stable.
The key with fixing a problem on the CI is being able to reproduce it locally.
Maybe there's a more stable way to write tests with timing.
If we aren't sure about TSAN on ubuntu, we can try to change some of the docker file and test with different versions of Linux. I've tested with a super recent version of fedora. Maybe we can write some kind of spreadsheet.
We can also research and make small repro case that we post in the oifficial Google TSAN github page, and ask for help there.

[bsergean]

There's also this problem which could be linked: #77

[bsergean]

This is the current problem now ; the other tsan problems are gone ; also close unittest isn't working as well.

[AlexandreK38]

Great if if the fix is working, I will have a look at the new errors when I can

[bsergean]

should be good now