WebSocketTransport::close method does not make sense

[machinezone]

WebSocketTransport::close method does not make sense

[bsergean]

@Kumamon38 can you explain how this method work ? This code does not make sense to me.

[Dimon4eg]

comment connection is opened, so close without sending close frame is not correct because below I see sendCloseFrame(code, reason);

[bsergean]

I like the new close unittest which looks sensible and which pass, there used to be bugs in that code, but I have to say that this code is now much more complex than it used to be and that it doesn't make much sense anymore.

[AlexandreK38]

There is also the OPENING state, but I wasn’t sure about if we can be in. I think we can remove the else part and the function

[AlexandreK38]

*and the comment

[AlexandreK38]

Cleaned 🧹

[bsergean]

This is much better now, closing. Thanks for the fix.