Comments (9)
Any updates to this?
from ec2-github-runner.
As to the table above, I think #53 (block device mappings, e.g. larger root volume), #3 (tags) and #6 (via instance profile) can also be covered by using a launch template.
from ec2-github-runner.
@machulav Here's a quick CloudFormation template for setting up an EC2 launch template (I'd imagine something like this would help users adopt launch templates): https://gist.github.com/jpalomaki/003c4d173a856cf64c6d35f8869a2de8. Subnet is currently left optional, so we can test if automatic AZ assignment could help with #60, and spot/public IP settings are exposed as optionals. EBS todo.
from ec2-github-runner.
Thank you! I will test it and try to figure out more details of what we can cover with this and get back to you.
from ec2-github-runner.
However, we would need to introduce v3 with a changed approach to using the action
I don't think this is necessarily the case. Launch templates provide overrideable defaults for selected instance parameters (see docs), so this could be made an optional input (retaining backwards-compatibility). One could then e.g. override the instance type defined in the launch template (if any) by passing one thru the instance-type
input.
from ec2-github-runner.
Yes, you're right, we can add one more input and retain the backward compatibility.
But we can also go the other way by introducing v3 and make the action simpler, and as a result, more stable:
- support only launch templates way of the EC2 runner configuration;
- use #56 approach by default;
- remove all the not useful parameters and functionality;
- make the documentation simpler.
What do you think?
from ec2-github-runner.
I like simplicity, so that plan for v3
definitely sounds reasonable. 👍 Consider placing those ideas in a v3 roadmap item or discussion.
That said, I do also like backwards-compatibility (even more so as this action seems to be quite widely used), so if we tested the launch template approach with v2
first, it might help us gather user experiences and get v3
right from the get-go.
from ec2-github-runner.
so if we tested the launch template approach with v2 first, it might help us gather user experiences and get v3 right from the get-go
That's actually a very good point! 🤔
from ec2-github-runner.
CloudFormation template now updated with most settings we have been looking at, including EBS, instance profile and example tags. I also tested it quickly with my Ubuntu AMI, seems to work.
from ec2-github-runner.
Related Issues (20)
- set-output deprecation
- stop action fails to find Github runner though the labeled runner does exist HOT 2
- Runners fail to register when IPs/hostnames are reused HOT 4
- Instance role when added not working HOT 2
- update the options for github runner setup script (config.sh)
- Runner is up and running but job isn't running on selfhosted runner HOT 2
- Support for c7g instances. HOT 1
- Add missing library to README / Arm64
- Make ec2-github-runner working with GITHUB_TOKEN generated into the Github Action workflow HOT 3
- EBS Volume doesn't get deleted HOT 1
- [feature request] make to be installed github runner version configurable
- [feature request] Make configurable pre-commands in user-data possible HOT 1
- is there a way to pass additional parameter to ec2 instance, like enable detail monitor? HOT 2
- Github Runner - not able to register itself in GitHub as a new self-hosted runner HOT 1
- [feature request] Allow use of Fine-grained personal access tokens
- Issue starting runner HOT 1
- [feature request] Allow requesting spot instance instead of an on-demand instance. HOT 7
- Error regarding ec2 os input HOT 1
- Unable to register self-hosted runner HOT 8
- Support node 20 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ec2-github-runner.