Giter Site home page Giter Site logo

Comments (9)

Preen avatar Preen commented on July 28, 2024 3

Any updates to this?

from ec2-github-runner.

jpalomaki avatar jpalomaki commented on July 28, 2024 1

As to the table above, I think #53 (block device mappings, e.g. larger root volume), #3 (tags) and #6 (via instance profile) can also be covered by using a launch template.

from ec2-github-runner.

jpalomaki avatar jpalomaki commented on July 28, 2024 1

@machulav Here's a quick CloudFormation template for setting up an EC2 launch template (I'd imagine something like this would help users adopt launch templates): https://gist.github.com/jpalomaki/003c4d173a856cf64c6d35f8869a2de8. Subnet is currently left optional, so we can test if automatic AZ assignment could help with #60, and spot/public IP settings are exposed as optionals. EBS todo.

from ec2-github-runner.

machulav avatar machulav commented on July 28, 2024 1

Thank you! I will test it and try to figure out more details of what we can cover with this and get back to you.

from ec2-github-runner.

jpalomaki avatar jpalomaki commented on July 28, 2024

However, we would need to introduce v3 with a changed approach to using the action

I don't think this is necessarily the case. Launch templates provide overrideable defaults for selected instance parameters (see docs), so this could be made an optional input (retaining backwards-compatibility). One could then e.g. override the instance type defined in the launch template (if any) by passing one thru the instance-type input.

from ec2-github-runner.

machulav avatar machulav commented on July 28, 2024

Yes, you're right, we can add one more input and retain the backward compatibility.

But we can also go the other way by introducing v3 and make the action simpler, and as a result, more stable:

  • support only launch templates way of the EC2 runner configuration;
  • use #56 approach by default;
  • remove all the not useful parameters and functionality;
  • make the documentation simpler.

What do you think?

from ec2-github-runner.

jpalomaki avatar jpalomaki commented on July 28, 2024

I like simplicity, so that plan for v3 definitely sounds reasonable. 👍 Consider placing those ideas in a v3 roadmap item or discussion.

That said, I do also like backwards-compatibility (even more so as this action seems to be quite widely used), so if we tested the launch template approach with v2 first, it might help us gather user experiences and get v3 right from the get-go.

from ec2-github-runner.

machulav avatar machulav commented on July 28, 2024

so if we tested the launch template approach with v2 first, it might help us gather user experiences and get v3 right from the get-go

That's actually a very good point! 🤔

from ec2-github-runner.

jpalomaki avatar jpalomaki commented on July 28, 2024

CloudFormation template now updated with most settings we have been looking at, including EBS, instance profile and example tags. I also tested it quickly with my Ubuntu AMI, seems to work.

from ec2-github-runner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.