N+1 Queries fix is wrong - include should be include*s*

[madeindjs]

N+1 Queries fix is wrong - include should be include*s*

[madeindjs]

Corrected with this commit.

[madeindjs]

Thre are two different includes:

1. Product.includes(:user) this one is from Active Record and it loads relations Product#user
2. options[:include] = [:user] this one is from fast_jsonapi options

But it seem that code example does not include includes(:user). I added warning disappeared:

Started GET "/api/v1/products" for ::1 at 2021-01-24 08:57:41 +0100
   (0.1ms)  SELECT sqlite_version(*)
Processing by Api::V1::ProductsController#index as JSON
   (0.2ms)  SELECT COUNT(*) FROM "products"
  ↳ app/controllers/concerns/paginable.rb:9:in `get_links_serializer_options'
  Product Load (0.2ms)  SELECT "products".* FROM "products" LIMIT ? OFFSET ?  [["LIMIT", 20], ["OFFSET", 0]]
  ↳ app/controllers/api/v1/products_controller.rb:17:in `index'
  User Load (0.6ms)  SELECT "users".* FROM "users" WHERE "users"."id" IN (?, ?, ?)  [["id", 7], ["id", 8], ["id", 9]]
  ↳ app/controllers/api/v1/products_controller.rb:17:in `index'
   (0.2ms)  SELECT "products"."id" FROM "products" WHERE "products"."user_id" = ?  [["user_id", 7]]
  ↳ app/controllers/api/v1/products_controller.rb:17:in `index'
   (0.1ms)  SELECT "products"."id" FROM "products" WHERE "products"."user_id" = ?  [["user_id", 8]]
  ↳ app/controllers/api/v1/products_controller.rb:17:in `index'
   (0.2ms)  SELECT "products"."id" FROM "products" WHERE "products"."user_id" = ?  [["user_id", 9]]
  ↳ app/controllers/api/v1/products_controller.rb:17:in `index'
Completed 200 OK in 50ms (Views: 2.4ms | ActiveRecord: 3.8ms | Allocations: 22119)

Can you try it and confirm that works?

[notapatch]

Yes, I got confused between the include for the serialization and the includes for the N+1 query.

On re-reading the section it now makes sense. Glad the code example is fixed as I would have checked my code against it when things didn't make sense.

Closing.