Giter Site home page Giter Site logo

Comments (2)

madelson avatar madelson commented on July 18, 2024

@jhorbulyk I've considered it but I'm not sure what the API can really do if this happens. It's not like I can cause the code inside the using block to abort. Likely the most we could do is to expose some kind of handle to this state in the return value that callers can check/subscribe to. It's still not perfect from a thread-safety perspective, since you could always lose the lock right after confirming that you have it.

What were you thinking that the API/behavior for this would look like?

In practice, I've never found this to be an issue, and I'm not even 100% sure at this point how much of a network blip will actually take out an inactive SqlConnection. I'm also not sure whether such an asynchronous failure would actually fire the StateChanged event in a background thread vs. only "noticing" the failure when you actually issue another query on that connection.

from distributedlock.

jhorbulyk avatar jhorbulyk commented on July 18, 2024

I was considering adding a CancellationToken that could be passed into the constructor that could be triggered in the event of a DB connection loss. However, you are correct in that asunchronous failures don't fire the StateChanged events on SqlConnection objects so this becomes a moot point.

from distributedlock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.