Giter Site home page Giter Site logo

Comments (2)

madelson avatar madelson commented on July 18, 2024 2

Hi @clement911 thanks for the suggestion. I agree that this is a good idea. A few thoughts:

  • Changing this would be a binary breaking change, so we would have to do it as part of a 2.0 release
  • It looks like .NET Core is working on a standard IAsyncDisposable interface for this (https://github.com/dotnet/corefx/issues/32640), so I would want to wait for that to be released and understand the implications of it (e .g. can you use it in a using block?) before building this.
  • Finally, some lock releases can't benefit from async (e. g. transaction-based locks release with SqlTransaction.Dispose(), which isn't async. That said, (a) maybe this will change when IAsyncDisposable comes out and (b) it doesn't stop us from implementing the interface for the cases where we will get the benefit.

from distributedlock.

clement911 avatar clement911 commented on July 18, 2024

Makes sense. Looking forward to IAsyncDisposable!

from distributedlock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.