Giter Site home page Giter Site logo

Comments (5)

Meir017 avatar Meir017 commented on July 18, 2024 1

@madelson I'll be happy to contribute here.
I was thinking of starting with the Redis provider here - I'll need to see how to enable just a subset of the test to make this be a gradual effort

From what I see on other projects using test-containers, we could just use the ubuntu image (see https://github.com/actions/runner-images/blob/ubuntu22/20240212.1/images/ubuntu/Ubuntu2204-Readme.md having docker already installed, and a working example https://github.com/filipsnastins/testcontainers-github-actions/actions/runs/7959995426/job/21728056781?pr=80)

from distributedlock.

madelson avatar madelson commented on July 18, 2024

I agree this would be a great idea, especially if it can create and easy path towards enabling a larger portion of the suite to run through GitHub actions.

@Meir017 is this something you’re interested in contributing? If so, let’s discuss what the implications would be for the code base and developer experience.

from distributedlock.

madelson avatar madelson commented on July 18, 2024

Redis makes sense as a place to start. The tests are pretty well organized by namespace/category (and more could be done if that’s not sufficient), so it shouldn’t be terribly difficult to run just the redis tests through nunit.

from distributedlock.

douglasg14b avatar douglasg14b commented on July 18, 2024

If you're talking about black box tests, you can standup a test environment in github actions with docker-compose, and run tests against those environments. You can add an abstraction over it with Tilt if desired.

This has the advantage of not leaking the test env into your code, but afaik is fundamentally the same as testcontainers 🤔

You end up just standup up the envs for redis, postgres....etc using their already existing images. It's quite convenient :)

from distributedlock.

Meir017 avatar Meir017 commented on July 18, 2024

@douglasg14b would this affect the local development experience? Would developers still need to install locally thr different dependencies?

from distributedlock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.