Giter Site home page Giter Site logo

Comments (1)

madelson avatar madelson commented on July 18, 2024 1

Hi @stephenpatten . I'm not sure I fully understand what you are trying to do and in particular what this means:

Wanted to decorate the SqlDistributedLock in such a fashion that the I can run other code to validate (beyond the acquired lock) that I truly have a lock on a business object.

One thing I'll note is that I'm not sure why you have your AWDSqlLock class implementing IDisposable. Maybe there is a reason for this separate from the code you've shown.

As you say, using is just syntax sugar over try-finally. The translation is this:

using (var handle = myLock.TryAcquire(...))
{
    ...
}

// translates to
var handle = myLock.TryAcquire(...);
try
{
   ...
}
finally 
{
    if (handle != null) { handle.Dispose(); }
}

In your case, it seems like you want to return the handle to the caller, so you wouldn't want a using block there because that would dispose the handle. Instead, the caller would have the using block:

AWDSqlLock awdLock = ...
using (var handle = awdLock.TryGetLock(...))
{
    if (handle != null) { /* got the lock: do something */ }
}

The one thing you should be careful of is that if AWDSqlLock is going to do any logic between acquiring the underlying SqlDistributedLock handle and returning it that could fail, then you want a try-catch to make sure the handle gets cleaned up promptly (otherwise you'd need to wait for GC). For example:

// check the distributed lock
if (sqlHandle != null)
{
      try
      {
          if (AdditionalBusinessLogic()) { return sqlHandle; }
      }       
      catch
      {
          sqlHandle.Dispose(); // clean up
          throw; // propagate the biz logic error
      }

      // result is neg
      sqlHandle.Dispose(); // clean up
      return null;
}

from distributedlock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.