Support for process restart

[madelson]

Support for process restart

[Wintereise]

Hi @madelson

Thank you for the insight, understood.

I'll close this.

[madelson]

Hi @Wintereise . While I suppose you can technically "re-start" a .NET process object by calling Start again it feels strange to me to do that since you are really just starting a completely new process. Calling Start again will blow away the std IO streams (as you are seeing) and could do weird things with subscribed events which makes code that uses this pattern prone to bugs.

MedallionShell takes the approach that processes are one-time events (Commands), e. g. associating each process with a Task which is not restartable.

Therefore, I think the best way to represent a process that may die with or without MedallionShell is to create an entirely new Command/Process object on each restart.

For example, if you want a process that auto-restarts on unexpected failure you could do something like this:

while (true)
{
    var command = ConfigureAndRunCommand(...)
         .RedirectTo(...);
    if ((await command.Task).Success) { break; }
}

In this case, we're taking advantage of a MedallionShell feature which makes sure all output has been written from redirection before allowing the Commands Task to finish. This makes sure that we won't hit thread-safety issues if the old and new process were being redirected to the same place.

If we want the ability to kill this loop ourselves, we can easily pass in a CancellationToken to Run using options.CancellationToken(...). That way, when cancellation is triggered it will (a) kill the process and (b) have the Command's task flip to the Canceled state, which will cause an OperationCanceledException to be thrown, exiting the loop.