Giter Site home page Giter Site logo

Comments (3)

madelson avatar madelson commented on June 16, 2024

Hi @1RedOne , are you passing the full path to the executable you are trying to run? For example, /sbin/ifconfig instead of just /ifconfig? One quick test you can do is to try running File.Exists on the same string that you're passing as the first argument to Run(). If File.Exists can't find it then Run() can't typically find it either.

Backlog issue #32 is about adding the abililty to search the system path for files like bash or cmd would do. From experience I've found that sometimes .NET seems to do a variant of this for us on Windows, sometimes not. It's been hard to pin down what the specific behavior is. I haven't explored the linux behavior too much, but it looks like it calls execve which does not seem to do any path searching, so I'd expect that working path is needed.

The other thing to think about is that if you're running bash built-in commands that are not standalone executables then you'll probably need to run these through bash itself. So in that case you'd have something like Command.Run("/path/to/bash", "command", "arg1", ...).

Let me know if that works? Maybe we can work towards some examples that can be added to the docs page?

from medallionshell.

1RedOne avatar 1RedOne commented on June 16, 2024

Thanks for the response, you were right about needing to provide the fully qualified path to the binary. On top of that, it turns out that when providing a string of command options to bash, there is some irksome quote management needed, here was the syntax that worked for me.

Command.Run("/path/to/bash", $"-c \"/usr/local/bin/youtube-dl --no-progress {cleanURL}\""),

Note the escaped quote after -c above, and the closing escaped quote. {cleanURL} is just a url that's inserted with string expansion using the $" " syntax.

from medallionshell.

madelson avatar madelson commented on June 16, 2024

@1RedOne thanks for following up. A few thoughts on the above:

  • Is there a reason to go through bash here? What happens if you just do:
Command.Run("/usr/local/bin/youtube-dl", "--no-progress", cleanUrl);
  • If you are going to use bash, I'm a bit surprised to see -c included as part of the single argument. Each argument passed to MedallionShell gets escaped so that the program being run sees it as a separate argument. In this case, we want to pass 2 args: the -c flag and the command line itself /usr/local/bin/youtube-dl --no-progress {cleanURL}. For example the following works for me on Windows. Does it work for you (with your bash path of course)?
Command.Run(@"C:\Program Files\Git\usr\bin\bash.exe", "-c", "echo hi")
  • RE: escaping, I wonder if this won't be required if you keep -c separate as suggested above. That way you can take advantage of MedallionShell's native escaping. Where I'd think you WOULD need escaping is if cleanURL happened to have spaces or backslashes in it. Can you try the following and let me know what the result is?
Command.Run("/path/to/bash", "-c", $"/usr/local/bin/youtube-dl --no-progress {cleanURL}");

from medallionshell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.