Comments (6)
Hi,
in our private fork, we just added mwst
as a possible identifier, since we used the MWST PDF set. This is of course only a partial solution, since there are many more possible names. Since MG normally uses LHAPDF for accessing PDF sets, working with the list at https://lhapdf.hepforge.org/pdfsets.html could be an option for you.
Btw, the identifier ct
was probably include, since there are CT PDF sets; the identifier pdf
for the PDF4LHC PDF sets.
Best,
Henning
from madminer.
Hi Henning,
Could you post a minimal example code that throws the error and whatever logs you have? Alternatively, pointing us to your working notebook could also be helpful.
Thank you,
Irina
from madminer.
Hi Irina,
the issue does not produce any error. To encounter it, one has to load a h5
file, which has been generated based on a .lhe
file with MG PDF reweighting. Loading it e.g. with
sampler = SampleAugmenter(
f"{paths['h5_sample_file']}",
include_nuisance_parameters=True,
)
one then encounters something like
13:44 madminer.analysis.da INFO Found 1 nuisance parameters
13:44 madminer.analysis.da INFO 0: scale (scale / mu / 0.5,1.0,2.0)
in the log, whereas the output should be something like
13:44 madminer.analysis.da INFO Found 41 nuisance parameters
13:44 madminer.analysis.da INFO 0: scale (scale / mu / 0.5,1.0,2.0)
13:44 madminer.analysis.da INFO 1: pdf (pdf / errorset)
which we got after fixing this issue in a private fork of MadMiner. The issue lies in the function extract_nuisance_parameters_from_lhe_file
which is called by the DelphesReader
and/or the LHEReader
.
Best,
Henning
P.S.: I would not regard this as an enhancement. For me, this is clearly a bug, since it is nowhere documented that systematic PDF uncertainties are only supported for PDFs with a name incorporating pdf
or ct
.
from madminer.
Hi @konda111
Thanks for opening this issue 😄
I understand this topic lays in a some-how grey area between bug and incomplete documentation. The if
block you mentioned in your issue description was introduced by Johann in this 2019 commit, only to be refactored by me very recently.
I would like to understand what other PDF weight names could we expect coming from a .lhe
file, in order to include them in the list of found nuisance parameters.
Could you point us to the fix in your private fork?
from madminer.
I see.
Our desirable fix would be to include an standardized list of prefixes / list of names, so that we should not need to open a similar issue in the future about why PDF set <introduce-name-here>
was not supported in the first place.
Wondering what is the best approach to tackle this... Any ideas? @johannbrehmer @irinaespejo @matthewfeickert
from madminer.
In order to unblock this issue and to encourage the usage of the main package, instead of a custom fork, I am going to add mwst
as one of the possible prefixes in this if
clock logic. You can expect the change to be available in the upcoming 0.9.2
version.
The issue will remain open for now, as we lack an standardized solution to cover all PDF datasets...
from madminer.
Related Issues (20)
- Migrate CI and CD from Travis CI to GitHub Actions workflows HOT 5
- Python 2 → 3 conversion error HOT 2
- [Bug?] An unsuitable calling to initializing function(__init__) of class MadMinerParticle HOT 10
- Define Jupyter notebooks automatic tests HOT 2
- [Internal] Define data models HOT 1
- LHE analysis error when parsing observables
- Bug in calculation of full Fisher information for ensemble with calculate_covariance=False HOT 1
- Crash in load_madminer_settings in files with custom observables HOT 13
- Increase test coverage
- Remove restrictions on Dependabot GitHub Actions update HOT 2
- Add Overdetermined morphing and addtional testings HOT 1
- Error calculating Fisher information in MadMiner(v0.9.3) HOT 6
- Systematics cannot be read by MadGraph HOT 3
- AttributeError: 'AsymptoticLimits' object has no attribute '_calculate_partition_bound' HOT 3
- Use gh-action-pypi-publish v1.7.0+ APIs HOT 2
- FileNotFoundError for event generation HOT 1
- Stuck in reweighting
- Possible error in filepath lookup?
- Add matthewfeickert as collaborator with owner role on PyPI HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from madminer.