segfault on hitting F key in Mageia

[barjac]

segfault on hitting F key in Mageia

[barjac]

Any comment on this please?

[linuxCowboy]

It's the same source in debian (my distro) and mageia:

 $ wget http://ftp.free.fr/mirrors/mageia.org/distrib/8/SRPMS/core/release/vbindiff-3.0-0.8.beta5.mga8.src.rpm

 $ rpm2cpio vbindiff-3.0-0.8.beta5.mga8.src.rpm |cpio -iv
vbindiff-3.0_beta5.tar.gz

 $ wget http://deb.debian.org/debian/pool/main/v/vbindiff/vbindiff_3.0-beta5.orig.tar.gz

 $ ls -l vbindiff-3.0_beta5.tar.gz vbindiff_3.0-beta5.orig.tar.gz
-rw-r--r-- 1 lxc lxc 128,406 Oct 25  2017 vbindiff_3.0-beta5.orig.tar.gz
-rw-r--r-- 1 lxc lxc 128,406 Feb 21 13:32 vbindiff-3.0_beta5.tar.gz

 $ diff -s vbindiff-3.0_beta5.tar.gz vbindiff_3.0-beta5.orig.tar.gz
Files vbindiff-3.0_beta5.tar.gz and vbindiff_3.0-beta5.orig.tar.gz are identical

I got your build:

 $ wget https://mirror.tuxinator.org/mageia/distrib/8/x86_64/media/core/release/vbindiff-3.0-0.8.beta5.mga8.x86_64.rpm

 $ rpm2cpio vbindiff-3.0-0.8.beta5.mga8.x86_64.rpm |cpio -ivd
./usr/bin/vbindiff

It failed in debian too:

 $ ./usr/bin/vbindiff vbindiff-3.0-0.8.beta5.mga8.src.rpm

Segmentation fault

 $ reset

You could try my patches? I implemented the searches new.

(But I don't think Mr. Madsen's code is faulty.)

[rofl0r]

vbindiff is a buggy, unmaintained PoS (piece of software) written in a horrible, unmaintainable language (C++). that's why i long gave up on it and you should too.
you can use haxdiff ( https://github.com/rofl0r/haxdiff ) + an editor that has syntax highlighting for diffs to replace it.

[barjac]

You could try my patches? I implemented the searches new.

Where are they? I see no patches in the Debian sources.

[linuxCowboy]

@barjac

I see you still haven't fixed your Mageia probs!

From your dump its visible that wresize is called with 4 args instead of 3?

@rofl0r

vbindiff is (for me) first of all a quick hexviewer. I don't see how haxdiff can compete with that.

And it's okay for me to get only the source of a good program. There is no obligation for a lifelong support!

[barjac]

@barjac

I see you still haven't fixed your Mageia probs!

From your dump its visible that wresize is called with 4 args instead of 3?

Where?
I only see it used once in ConWindow::resize with 3 params.
if (wresize(win, height, width) != OK)
Are you suggesting that our optimization is causing this?
I am not a programmer so if you can offer more than cryptic comments I would appreciate your help. ;)

[linuxCowboy]

"cryptic comments"... hmm...

It looks like a widechar problem to me.

And indeed, install the ncurses utf8 development libraries

lib64ncursesw-devel

run

./configure LIBS="-lncursesw -lpanelw" && make

and vbindiff is back in the game!

Tested with
Mageia 8 Live Xfce 64bit

[barjac]

"cryptic comments"... hmm...
:-)

Many thanks for you help - much appreciated - fix now pushed in Mageia 8 updates_testing and in cauldron.