Refactor batched triggered abilities to expose which part of batch event made them trigger.

[Susucre]

Refactor batched triggered abilities to expose which part of batch event made them trigger.

[github-actions]

Felix Five-Boots - (Gatherer) (Scryfall) (EDHREC)

{2}{B}{G}{U}
Legendary Creature — Ooze Rogue
5/4
Menace, ward {2}
If a creature you control dealing combat damage to a player causes a triggered ability of a permanent you control to trigger, that ability triggers an additional time.

Umezawa's Jitte - (Gatherer) (Scryfall) (EDHREC)

{2}
Legendary Artifact — Equipment
Whenever equipped creature deals combat damage, put two charge counters on Umezawa's Jitte.
Remove a charge counter from Umezawa's Jitte: Choose one —
• Equipped creature gets +2/+2 until end of turn.
• Target creature gets -1/-1 until end of turn.
• You gain 2 life.
Equip {2}

[JayDi85]

Can you make reproducible test for master with wrong triggers?

[Susucre]

I don't think the current trigger-caring cards can cause issue at the moment.
Need the Felix text, of "If a creature you control dealing combat damage to a player causes a triggered ability of a permanent you control to trigger, ", which is looking at specifically batchs.

[Susucre]

There might be, but it needs to be a combination of one of those:
https://scryfall.com/search?q=o%3A%22causes+a+triggered+ability%22
And a batch triggers that filters a batch event in an disjoint way.

I didn't find the Jitte+Felix example quickly, so maybe there are actual exemple with current cards.

[JayDi85]

Maybe it’s possible to use test with custom card. See good usage example from commit crime mechanics: https://github.com/magefree/mage/pull/11859/files#diff-ea86893179679bbafef2d79b9257e24555b8e297789eb3be67a05eadaf6bf5f0

[Susucre]

I think this should be an affected case (blinking wizard non-artifact + non-wizard artifact with [[Naban, Dean]] + [[Ingenious artillerist]]):

But Naban is bugged and not looking at batchs:

I'll try to find another with non-bugged card.

[github-actions]

Naban, Dean of Iteration - (Gatherer) (Scryfall) (EDHREC)

{1}{U}
Legendary Creature — Human Wizard
2/1
If a Wizard entering the battlefield under your control causes a triggered ability of a permanent you control to trigger, that ability triggers an additional time.

Unable to retrieve information for "Ingenious artificer"

[github-actions]

Ingenious Artillerist - (Gatherer) (Scryfall) (EDHREC)

{2}{R}
Creature — Human Artificer
3/1
Whenever one or more artifacts enter the battlefield under your control, Ingenious Artillerist deals that much damage to each opponent.

[Susucre]

I have not looked at all of them, but the move zones "If [...] causes a triggered ability of [...] to trigger," all seem to not work on batch move events.
So the refactor I propose is even more needed to rework those cards.

[xenohedron]

Interesting find. Is the bug only applicable to NUMBER_OF_TRIGGERS?

[Susucre]

Interesting find. Is the bug only applicable to NUMBER_OF_TRIGGERS?

I do think so. This should be the only meta-trigger?