Giter Site home page Giter Site logo

Comments (11)

github-actions avatar github-actions commented on June 12, 2024

Industrial Advancement - (Gatherer) (Scryfall) (EDHREC)

{3}{R}
Enchantment
At the beginning of your end step, you may sacrifice a creature. If you do, look at the top X cards of your library, where X is that creature's mana value. You may put a creature card from among them onto the battlefield. Put the rest on the bottom of your library in a random order.

Junji, the Midnight Sky - (Gatherer) (Scryfall) (EDHREC)

{3}{B}{B}
Legendary Creature — Dragon Spirit
5/5
Flying, menace
When Junji, the Midnight Sky dies, choose one —
• Each opponent discards two cards and loses 2 life.
• Put target non-Dragon creature card from a graveyard onto the battlefield under your control. You lose 2 life.

from mage.

alexander-novo avatar alexander-novo commented on June 12, 2024

Another example:

image

image

Kogla had undying and no counters, but undying didn't trigger,

from mage.

alexander-novo avatar alexander-novo commented on June 12, 2024

Actually this might just be a general problem with sacrifice. Here's another log:

image

Here, I sacrifice Atsushi with [[Vivien on the Hunt]]'s +2 ability, and it doesn't activate Atsushi's death trigger.

from mage.

github-actions avatar github-actions commented on June 12, 2024

Vivien on the Hunt - (Gatherer) (Scryfall) (EDHREC)

{4}{G}{G}
Legendary Planeswalker — Vivien
4
+2: You may sacrifice a creature. If you do, search your library for a creature card with mana value equal to 1 plus the sacrificed creature's mana value, put it onto the battlefield, then shuffle.
+1: Mill five cards, then put any number of creature cards milled this way into your hand.
−1: Create a 4/4 green Rhino Warrior creature token.

from mage.

alexander-novo avatar alexander-novo commented on June 12, 2024

Sacrificing with [[Evolutionary Leap]] seems to work fine, though...

from mage.

github-actions avatar github-actions commented on June 12, 2024

Evolutionary Leap - (Gatherer) (Scryfall) (EDHREC)

{1}{G}
Enchantment
{G}, Sacrifice a creature: Reveal cards from the top of your library until you reveal a creature card. Put that card into your hand and the rest on the bottom of your library in a random order.

from mage.

alexander-novo avatar alexander-novo commented on June 12, 2024

image

It seems it's only missing the triggers on the sacrificed permanent - in this example, The Skullspore Nexus triggers from the sacrifice, but not Protean Hulk itself.

from mage.

JayDi85 avatar JayDi85 commented on June 12, 2024
  1. Is it regression from last updates?
  2. Is it affect cards with multiple modes only?

from mage.

alexander-novo avatar alexander-novo commented on June 12, 2024
  1. Is it regression from last updates?

  2. Is it affect cards with multiple modes only?

It must be a regression... there's no way this has been broken for very long. Also it's not multiple modes - cards like [[Protean Hulk]] don't work and also cards with undying. I'm planning on writing a unit test for it and doing a git bisect on it.

from mage.

github-actions avatar github-actions commented on June 12, 2024

Protean Hulk - (Gatherer) (Scryfall) (EDHREC)

{5}{G}{G}
Creature — Beast
6/6
When Protean Hulk dies, search your library for any number of creature cards with total mana value 6 or less, put them onto the battlefield, then shuffle.

from mage.

alexander-novo avatar alexander-novo commented on June 12, 2024

Actually this may not be a regression...

I've tested on 229e8d3 and it also had the bug. Let me go back further

from mage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.