Giter Site home page Giter Site logo

Comments (6)

kirmorozov avatar kirmorozov commented on May 4, 2024

It's definitely bad idea.
All browsers have their specific css(ex: mos for firefox).
Please fix your css instead of making mess.

from magento2.

jigneshthummar avatar jigneshthummar commented on May 4, 2024

@kirmorozov yeah u r right browser have their specific css properties,

but its idea for common properties some Wordpress sites use same trick.

from magento2.

kirmorozov avatar kirmorozov commented on May 4, 2024

What stops you from adding this class using JavaScript. It won't affect performance much and it wont affect server performance at all.
@jigneshthummar IMHO this is the way to fix some bug with own css.

P.S. Probably you didn't heard of http://code.google.com/p/ie7-js/

from magento2.

Flyingmana avatar Flyingmana commented on May 4, 2024

i have used https://github.com/rafaelp/css_browser_selector for this since some time now.
So either you dont care about this, and give a note in manual to this library or add this as standard library (what sure has its benefits)

And if we talk about this, http://modernizr.com/ belongs in the same area, than many things are depending on a feature, not on a browser.

In any case, its a theming question. Maybe its the best to have a more simple js-less main theme, and an additional "perfect" theme which makes havy use of js.

from magento2.

magento-team avatar magento-team commented on May 4, 2024

@jigneshthummar
Thank you for suggestion. We'll not implement it though -- as @kirmorozov and @Flyingmana pointed out, there are more effective solutions are possible without affecting server performance.

from magento2.

jigneshthummar avatar jigneshthummar commented on May 4, 2024

Ok thanks @Flyingmana @kirmorozov for their valuable suggestions :)

from magento2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.