Giter Site home page Giter Site logo

Comments (9)

m2-assistant avatar m2-assistant commented on May 18, 2024

Hi @ivanko-dev. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

from magento2.

m2-assistant avatar m2-assistant commented on May 18, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

from magento2.

engcom-Bravo avatar engcom-Bravo commented on May 18, 2024

Hi @ivanko-dev,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Steps to reproduce

  • Display MXN, MAD, SAR, BHD, ... currency for de_DE locale in store.

We are able to get the all configured currencies in German store.

MXN Currency

Test (2)

MAD Currency

Test (3)

BHD Currency

Test (4)

SAR Currency

Test (5)

Kindly recheck the behaviour on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible.

Thanks.

from magento2.

engcom-Bravo avatar engcom-Bravo commented on May 18, 2024

Hi @ivanko-dev,

Kindly provide latest update on this comment #37780 (comment) still you are working on this issue if you are able to reproduce the issue please elaborate the steps to reproduce and let us know if you are still facing any issue.

Thanks.

from magento2.

ivanko-dev avatar ivanko-dev commented on May 18, 2024

Hello @engcom-Bravo
I am sorry I was not able to look into this issue earlier.

These are steps to reproduce it on the admin panel:

  1. Change locale for admin user to "Deutsch (Deutschland)" to get de_DE like a main locale for admin panel config
  2. Configure Base Currency (Stores -> Configuration -> General -> Currency Setup -> Currency Options -> Base Currency) to use Mexican peso
  3. Clear cache
  4. Start to create a new order from admin panel and try to add products to order
    Received result: all items in the products list use "$" for Mexican peso
    image
    Expected result: all items in the products list use "MX$" for Mexican peso (screenshot below received on local server with excluding \Magento\Framework\Currency\Data\Currency::$displayLocale for locales forced change)
    image

Initially, I got this issue in the custom module code, which loaded multiple currency data on the same store product page. I didn't investigate all sequences of actions in detail but looks like \Magento\Framework\Currency\Data\Currency::$displayLocale property forces to change the locale for loading currency symbols data, when the initial currency for locale was already loaded. Probably this was done to prevent cases when no currency symbol specified in the currency locale configuration file (eg. no config for MXN into Resources/data/currencies/ak.php file in symfony/intl package, but it exists in Resources/data/currencies/de.php).

I am not sure if this is important issue, because it was not confirmed on store frontend pages at this moment, but I think would be good to confirm what is the purpose of mentioned several times property with currency - locale pairs: \Magento\Framework\Currency\Data\Currency::$displayLocale

from magento2.

engcom-Bravo avatar engcom-Bravo commented on May 18, 2024

Hi @ivanko-dev,

Thanks for your update.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps To Reproduce

  • Change locale for admin user to "Deutsch (Deutschland)" to get de_DE like a main locale for admin panel config
  • Configure Base Currency (Stores -> Configuration -> General -> Currency Setup -> Currency Options -> Base Currency) to use Mexican peso
  • Clear cache
  • Start to create a new order from admin panel and try to add products to order

We have Mexican peso as a base currency it is showing MX$ in admin and frontend.

Screenshot 2023-08-09 at 12 05 58 PM Screenshot 2023-08-09 at 12 06 08 PM

While placing an order in admin it is showing in $ for the products.

Screenshot 2023-08-09 at 12 06 30 PM

But after adding the products to the cart it is showing usually as a MX$ while placing an order in admin panel.

Screenshot 2023-08-09 at 12 06 58 PM

Hence Confirming the issue.

Thanks.

from magento2.

github-jira-sync-bot avatar github-jira-sync-bot commented on May 18, 2024

✅ Jira issue https://jira.corp.adobe.com/browse/AC-9293 is successfully created for this GitHub issue.

from magento2.

m2-assistant avatar m2-assistant commented on May 18, 2024

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

from magento2.

ivanko-dev avatar ivanko-dev commented on May 18, 2024

I can try to fix this issue, single question, what is purpose of \Magento\Framework\Currency\Data\Currency::$displayLocale in the code for loading symbol?

from magento2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.