Comments (11)
Hello @Genaker,
Thank you for the quick response!
Verified this issue on 2.4-develop.
When checking out from a guest quote programmatically, after assigning a customer to the quote, customer_is_guest
remains 1
.
Please take a look at the screenshot below:
The value of customer_is_guest
should have been 0
, but it remains 1
.
Hence confirming this issue.
Please find the custom module used to reproduce this issue.
I38540V.zip
Thank you.
from magento2.
Hi @Genaker. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
@magento give me 2.4-develop instance
- upcoming 2.4.x release- For more details, review the Magento Contributor Assistant documentation.
- Add a comment to assign the issue:
@magento I am working on this
- To learn more about issue processing workflow, refer to the Code Contributions.
Join Magento Community Engineering Slack and ask your questions in #github channel.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.
from magento2.
there is test cases:
$customer = $this->customerRepository->getById($customerId);
$output->writeln('is order for guest : ' . $quote->getCustomerIsGuest());
$output->writeln("Customer ID:" . $customer->getId());
// Assign the customer to the quote
$quote->assignCustomer($customer);
$quote->setCustomerId($customer->getId());
$output->writeln('is order for guest after assign customer and set customer ID : ' . $quote->getCustomerIsGuest());
$output->writeln('is order for guest after set setCustomerIsGuest : ' . $quote->getCustomerIsGuest());
output 👍
the same issue for quote/cart or for order doesn't matte.
please fix this issue in the core.
from magento2.
Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
-
- Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
-
- Verify that issue has a meaningful description and provides enough information to reproduce the issue.
-
- Add
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to.
- Add
-
- Verify that the issue is reproducible on
2.4-develop
branchDetails
- Add the comment@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on2.4-develop
branch, please, add the labelReproduced on 2.4.x
.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
- Verify that the issue is reproducible on
- Join Magento Community Engineering Slack and ask your questions in #github channel.
from magento2.
Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
- 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
- 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
- 3. Add
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to. - 4. Verify that the issue is reproducible on
2.4-develop
branchDetails
- Add the comment@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on2.4-develop
branch, please, add the labelReproduced on 2.4.x
.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here! - 5. Add label
Issue: Confirmed
once verification is complete. - 6. Make sure that automatic system confirms that report has been added to the backlog.
from magento2.
Hello @Genaker,
Thank you for the report and contribution!
Tried to verify this issue on 2.4-develop, but in our case it is not reproducible.
Signed in as a customer, and added the product to cart, but customer_is_guest
was 0
.
Please take a look at the screenshot below:
Please let us know if any preconditions are required for the issue to be reproduced, and also if we are missing anything.
Thank you.
from magento2.
You should submit an order not through the front but by code: it is not a front issue
$quoteMaskedHash = //Real cart with the items mask
$quoteId = $this->getQuoteIdFromMaskedHash($quoteMaskedHash);
$customerId = //SomeCustomerID
$quote = $this->quoteRepository->get($quoteId);
$customer = $this->customerRepository->getById($customerId);
// Assign the customer to the quote there quote must be not guest
$quote->assignCustomer($customer);
$billingAddress = [
'firstname' => 'John',
'lastname' => 'Doe',
'email' => '[email protected]',
'street' => '123 Main St',
'city' => 'Anytown',
'country_id' => 'US',
'region' => 'NY',
'postcode' => '12345',
'telephone' => '1234567890',
'save_in_address_book' => 0
];
$quote->getBillingAddress()->addData($billingAddress);
$shippingAddress = [
'firstname' => 'John',
'lastname' => 'Doe',
'email' => '[email protected]',
'street' => '123 Main St',
'city' => 'Anytown',
'country_id' => 'US',
'region' => 'NY',
'postcode' => '12345',
'telephone' => '1234567890',
'save_in_address_book' => 0
];
$quote->getShippingAddress()->addData($shippingAddress);
$shippingAddress = $quote->getShippingAddress();
$shippingAddress->setCollectShippingRates(true)
->collectShippingRates()
->setShippingMethod('freeshipping_freeshipping'); // For Free Shipping
$quote->setPaymentMethod('checkmo'); // For Check / Money order
$quote->setInventoryProcessed(false); // Prevents inventory decrement
$quote->getPayment()->importData(['method' => 'checkmo']);
// Attempt to save the quote and create an order from it
$quote->collectTotals()->save();
///Quote is still guest
from magento2.
✅ Jira issue https://jira.corp.adobe.com/browse/AC-11689 is successfully created for this GitHub issue.
from magento2.
✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
from magento2.
❌ You don't have permission to export this issue.
from magento2.
@magento I am working on this
from magento2.
Related Issues (20)
- Cart price rule created for logged in user incorrectly gets applied for not logged in user HOT 9
- Layout action overrides order HOT 1
- 2.4.7-p1 incompatible with magento/module-b2b HOT 4
- PayPal’s Client-side only JavaScript SDK on or after 31 July 2024! HOT 4
- Rest cart item update throws `The requested qty is not available` if quantity in cart and quantity to update to exceeds stock HOT 10
- UPS API Change Request HOT 7
- Used gift card amount also refunding while doing the credit memo HOT 8
- Magento admin is not working or not able to changes HOT 6
- Unable to modify articles HOT 6
- [BACKEND] Select action dropdown menu is not fully displayed HOT 3
- Order by SKU feature is not working properly when trying to add out of stock product into the cart HOT 12
- Minicart cannot be used twice in the same page HOT 8
- Checkout address validation fails HOT 5
- [Issue] Remove references to files from extjs which got removed in e1ccdb… HOT 4
- [Issue] Fix typo in PHPDoc block
- Product page error "The OTP window must be a numeric value" HOT 12
- CSP Subresource Integrity sri Hashes in checkout_index_index causes big loadingtimes and bytes in multistore and sriHashes vanish after Cache Flush HOT 1
- Sortorder on Grid filters doesn't be available or valid with diffirent type of filters: Range vs others HOT 1
- How to Sold Out Product Auto go at the end of the Page or the last page of the Category HOT 2
- Advance Search Option looking for Magento 2 Website HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magento2.