Comments (40)
@digitalrisedorset Check you email :)
from magento2.
@digitalrisedorset I think you have to set "Origin of the Shipment" to, for example, "Shipments Originating in United States".
The weight unit parameter may depend on the Magentos origin settings, Sales->Shipping settings->Origin, but I'm not 100% sure.
Our Origin, for example, is Sweden which uses KGS. If origin is US which use LBS.
Do some testing based on that, I think you will figure it out.
from magento2.
@digitalrisedorset I can confirm those settings work for me as long as I have LBS as weight unit.
Changing the "Origin of the Shipment" to "Europe", weight to KGS and the "Shipping Origin" to our address, "77463, Dalarnas Län, Avesta, Sweden", will break it.
I've just spent a short time on this, but this is what I've found out so far.
UPS will return rates if:
- Magento origin is set to a US address (will probably work with Canada and a lot of other countries as well)
- UPS weight unit is set to: LBS
- UPS origin setting doesn't matter if above is set.
UPS will NOT return rates if:
- UPS weight unit is set to; KGS
UPS will NOT return rates if:
- Magento origin is set to "77463, Dalarnas Län, Avesta, Sweden"
I want to setup my store like this:
- Magento origin: "77463, Dalarnas Län, Avesta, Sweden"
- UPS weight unit is set to: KGS
- UPS origin: Europe
I can change line 1155 in /vendor/magento/module-ups/Model/Carrier.php -> "Code" => "CM", to make it work with above settings.
from magento2.
@digitalrisedorset Yes, I've noticed that also.
I cannot find an option to set or use dimensions in the UPS settings section so I guess the hardcoded 5x5x5 is there for some kind of fallback 🤔
from magento2.
@sanmic the PR is now in review, I have tested today all the use cases you have mentioned and all is working with the simple changes added.
from magento2.
Hi @sanmic. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
@magento give me 2.4-develop instance
- upcoming 2.4.x release- For more details, review the Magento Contributor Assistant documentation.
- Add a comment to assign the issue:
@magento I am working on this
- To learn more about issue processing workflow, refer to the Code Contributions.
Join Magento Community Engineering Slack and ask your questions in #github channel.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.
from magento2.
@magento give me 2.4-develop instance - upcoming 2.4.x release
from magento2.
Hi @sanmic. Thank you for your request. I'm working on Magento instance for you.
from magento2.
Hi @sanmic! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team
command to join Contributors team.
from magento2.
Hi @sanmic, here is your Magento Instance: https://b2437ad179063c5f7eb8a7bbdd57dc08.instances-prod.magento-community.engineering
Admin access: https://b2437ad179063c5f7eb8a7bbdd57dc08.instances-prod.magento-community.engineering/admin_cb7b
Login: 6fb81ec6
Password: 3fb4d7b8b374
from magento2.
Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
-
- Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
-
- Verify that issue has a meaningful description and provides enough information to reproduce the issue.
-
- Add
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to.
- Add
-
- Verify that the issue is reproducible on
2.4-develop
branchDetails
- Add the comment@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on2.4-develop
branch, please, add the labelReproduced on 2.4.x
.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
- Verify that the issue is reproducible on
- Join Magento Community Engineering Slack and ask your questions in #github channel.
from magento2.
Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
- 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
- 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
- 3. Add
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to. - 4. Verify that the issue is reproducible on
2.4-develop
branchDetails
- Add the comment@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on2.4-develop
branch, please, add the labelReproduced on 2.4.x
.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here! - 5. Add label
Issue: Confirmed
once verification is complete. - 6. Make sure that automatic system confirms that report has been added to the backlog.
from magento2.
@magento give me 2.4-develop instance - upcoming 2.4.x release
from magento2.
Hi @sanmic. Thank you for your request. I'm working on Magento instance for you.
from magento2.
Hi @sanmic, here is your Magento Instance: https://b2437ad179063c5f7eb8a7bbdd57dc08.instances-prod.magento-community.engineering
Admin access: https://b2437ad179063c5f7eb8a7bbdd57dc08.instances-prod.magento-community.engineering/admin_5a0f
Login: d7361ba1
Password: f4687c1b2cca
from magento2.
To reproduce:
Sales -> Delivery methods -> UPS
Set Origin of the Shipment to Shipments Originating in the European Union
Set Weight Unit to KGS
No UPS rates is visible in frontend.
If Weight Unit is set to LBS rates is visible in fronted.
I can see by myself that LBS is hardcoded in the core files.
from magento2.
from magento2.
Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x
, ^Area:.*
Once all required labels are present, please add Issue: Confirmed
label again.
from magento2.
Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x
, ^Area:.*
Once all required labels are present, please add Issue: Confirmed
label again.
from magento2.
Hi @sanmic ,
Verified the issue and the issue is reproducible.
Hence, Confirming the issue.
Steps to reproduce
- Sales -> shipping methods -> UPS
- Enable UPS method
- Set Origin of the Shipment to Shipments Originating in the European Union
- Set Weight Unit to KGS
- Go to frontend and verify the shipping methods available
Please refer the attached screenshot
from magento2.
✅ Jira issue https://jira.corp.adobe.com/browse/AC-11811 is successfully created for this GitHub issue.
from magento2.
✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
from magento2.
❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-11811
from magento2.
@engcom-Delta How can I add a Add label to the ticket? "Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to."
Hi @sanmic , I have added the labels on the ticket. Let us know if you need any changes.
from magento2.
@sanmic I can reproduce this issue, while analysing the same, i can see that
- If we setup config with LBS we get the results for rates quotes:
- If we config KGS to get the Rate data we do not get the results.
I am checking on how the weight/Dimension units are affecting the results as it is known the measurement units sometimes are not valid for the given country: Here with the same payload i have tried with both LBS/KGS & INCHES/CM
The analysis is in progress and thank you for this finding , we shall see on how to incorporate the dynamic Measurement units for Rates Quote Data, as we might need to implement the country based UPS support for the same.
from magento2.
@sanmic To add more to the issue:
UPS has global Unit Of measures "IN" and "CM" and they needs to be used as per the "Weight" units that we are using in our UPS admin configurations. We are working on the implementations of the same, we will update here on the progress.
If you're using kilograms (KGS) as the weight unit, ensure that you are also using centimeters (CM) as the unit for dimensions (length, width, and height).
If you're using pounds (LBS) or ounces (OZS) as the weight unit, ensure that you are using inches (IN) as the unit for dimensions (length, width, and height).
That is what we can understand with the given error response :
"A shipment cannot have a KGS/IN or LBS/CM or OZS/CM as its unit of measurements"
Other than that while configuring the UPS in admin you can make sure you setup the Weight unit as per the Shipper country origin by confirming the same on UPS support.
from magento2.
@glo05363 I have pretty good knowledge about the UPS shipping API.
We have developed an application for creating the UPS shipments and are aware of the sensitive settings for weight and dimensions (we ship from Sweden).
In this case we only use the UPS settings in Magento to show the rates in the cart and checkout.
A builtin time-in-transit function would be nice in Magento as well :)
from magento2.
Hi @sanmic,
Our internal team is working on the issue and we have following updates
Please refer the Comments:
Thanks.
from magento2.
@magento I am working on this
from magento2.
Do we have some UPS access details to use to replicate the issue on a local environment?
from magento2.
@digitalrisedorset Have you been able to get UPS access details?
from magento2.
@sanmic no I have not. I got as far as creating the UPS account but a lot of settings were required and by the time I had the setup created to handle the task, I was doomed to have setup the UPS service differently to what is needed to replicate the issue we have in this ticket. So, I'd like instead to verify if I can use a test UPS environment that is ready to use to just perform the Magento test and fix after this
from magento2.
@sanmic no I have not. I got as far as creating the UPS account but a lot of settings were required and by the time I had the setup created to handle the task, I was doomed to have setup the UPS service differently to what is needed to replicate the issue we have in this ticket. So, I'd like instead to verify if I can use a test UPS environment that is ready to use to just perform the Magento test and fix after this
@digitalrisedorset I guess I can create a UPS test app / credentials so you can continue your work.
I'll need a Callback URL and an email or similar to send the details.
from magento2.
Hi @sanmic , I have setup a demo site at https://demo.digitalrisedorset.co.uk/ and the email may be [email protected]. Many thanks
from magento2.
@sanmic .. we should be almost there. I have setup UPS, to start with, I'd like to verify I can get it to work as per the screenshots above, I have setup the credentials with European origin and yet Pounds rather than Kgs. I have also used an address from the states. I attach both screenshots. Am I missing something?
I will start troubleshooting either way, thank you very much indeed
from magento2.
@sanmic I am not lucky just yet.. I have a successful response and in fact, some times for possible delivery time do appear. Unfortunately, it does return eventually the error message that UPS is not available. I will try to read more on UPS before debugging further. I apologise, it seems to be something that will take a while.
{
"RateResponse":{
"Response":{
"ResponseStatus":{
"Code":"1",
"Description":"Success"
},
"Alert":[
{
"Code":"110971",
"Description":"Your invoice may vary from the displayed reference rates"
},
{
"Code":"120902",
"Description":"Negotiated rates cannot be returned without a valid account number."
},
{
"Code":"111685",
"Description":"TPFCNegotiatedRatesIndicator is applicable only for Third party/Freight Collect shipments."
}
],
"TransactionReference":{
"CustomerContext":"Rating and Service"
}
},
"RatedShipment":[
{
"Disclaimer":{
"Code":"05",
"Description":"Rate excludes VAT. Rate includes a fuel surcharge, but excludes taxes, duties and other charges that may apply to the shipment."
},
"Service":{
"Code":"01",
"Description":""
},
"RatedShipmentAlert":[
{
"Code":"120902",
"Description":"Negotiated rates cannot be returned without a valid account number."
},
{
"Code":"110971",
"Description":"Your invoice may vary from the displayed reference rates"
}
],
"BillingWeight":{
"UnitOfMeasurement":{
"Code":"LBS",
"Description":"Pounds"
},
"Weight":"2.0"
},
"TransportationCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"106.66"
},
"ServiceOptionsCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"0.00"
},
"TotalCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"106.66"
},
"GuaranteedDelivery":{
"BusinessDaysInTransit":"1",
"DeliveryByTime":"10:30 A.M."
},
"RatedPackage":{
"TransportationCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"106.66"
},
"ServiceOptionsCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"0.00"
},
"TotalCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"106.66"
},
"Weight":"2.0",
"BillingWeight":{
"UnitOfMeasurement":{
"Code":"LBS",
"Description":"Pounds"
},
"Weight":"2.0"
}
}
},
{
"Disclaimer":{
"Code":"05",
"Description":"Rate excludes VAT. Rate includes a fuel surcharge, but excludes taxes, duties and other charges that may apply to the shipment."
},
"Service":{
"Code":"02",
"Description":""
},
"RatedShipmentAlert":[
{
"Code":"120902",
"Description":"Negotiated rates cannot be returned without a valid account number."
},
{
"Code":"110971",
"Description":"Your invoice may vary from the displayed reference rates"
}
],
"BillingWeight":{
"UnitOfMeasurement":{
"Code":"LBS",
"Description":"Pounds"
},
"Weight":"2.0"
},
"TransportationCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"42.22"
},
"ServiceOptionsCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"0.00"
},
"TotalCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"42.22"
},
"GuaranteedDelivery":{
"BusinessDaysInTransit":"2"
},
"RatedPackage":{
"TransportationCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"42.22"
},
"ServiceOptionsCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"0.00"
},
"TotalCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"42.22"
},
"Weight":"2.0",
"BillingWeight":{
"UnitOfMeasurement":{
"Code":"LBS",
"Description":"Pounds"
},
"Weight":"2.0"
}
}
},
{
"Disclaimer":{
"Code":"05",
"Description":"Rate excludes VAT. Rate includes a fuel surcharge, but excludes taxes, duties and other charges that may apply to the shipment."
},
"Service":{
"Code":"03",
"Description":""
},
"RatedShipmentAlert":[
{
"Code":"120902",
"Description":"Negotiated rates cannot be returned without a valid account number."
},
{
"Code":"110971",
"Description":"Your invoice may vary from the displayed reference rates"
}
],
"BillingWeight":{
"UnitOfMeasurement":{
"Code":"LBS",
"Description":"Pounds"
},
"Weight":"2.0"
},
"TransportationCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"15.12"
},
"ServiceOptionsCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"0.00"
},
"TotalCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"15.12"
},
"RatedPackage":{
"TransportationCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"15.12"
},
"ServiceOptionsCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"0.00"
},
"TotalCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"15.12"
},
"Weight":"2.0",
"BillingWeight":{
"UnitOfMeasurement":{
"Code":"LBS",
"Description":"Pounds"
},
"Weight":"2.0"
}
}
},
{
"Disclaimer":{
"Code":"05",
"Description":"Rate excludes VAT. Rate includes a fuel surcharge, but excludes taxes, duties and other charges that may apply to the shipment."
},
"Service":{
"Code":"12",
"Description":""
},
"RatedShipmentAlert":[
{
"Code":"120902",
"Description":"Negotiated rates cannot be returned without a valid account number."
},
{
"Code":"110971",
"Description":"Your invoice may vary from the displayed reference rates"
}
],
"BillingWeight":{
"UnitOfMeasurement":{
"Code":"LBS",
"Description":"Pounds"
},
"Weight":"2.0"
},
"TransportationCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"33.64"
},
"ServiceOptionsCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"0.00"
},
"TotalCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"33.64"
},
"GuaranteedDelivery":{
"BusinessDaysInTransit":"3"
},
"RatedPackage":{
"TransportationCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"33.64"
},
"ServiceOptionsCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"0.00"
},
"TotalCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"33.64"
},
"Weight":"2.0",
"BillingWeight":{
"UnitOfMeasurement":{
"Code":"LBS",
"Description":"Pounds"
},
"Weight":"2.0"
}
}
},
{
"Disclaimer":{
"Code":"05",
"Description":"Rate excludes VAT. Rate includes a fuel surcharge, but excludes taxes, duties and other charges that may apply to the shipment."
},
"Service":{
"Code":"13",
"Description":""
},
"RatedShipmentAlert":[
{
"Code":"120902",
"Description":"Negotiated rates cannot be returned without a valid account number."
},
{
"Code":"110971",
"Description":"Your invoice may vary from the displayed reference rates"
}
],
"BillingWeight":{
"UnitOfMeasurement":{
"Code":"LBS",
"Description":"Pounds"
},
"Weight":"2.0"
},
"TransportationCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"97.20"
},
"ServiceOptionsCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"0.00"
},
"TotalCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"97.20"
},
"GuaranteedDelivery":{
"BusinessDaysInTransit":"1"
},
"RatedPackage":{
"TransportationCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"97.20"
},
"ServiceOptionsCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"0.00"
},
"TotalCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"97.20"
},
"Weight":"2.0",
"BillingWeight":{
"UnitOfMeasurement":{
"Code":"LBS",
"Description":"Pounds"
},
"Weight":"2.0"
}
}
},
{
"Disclaimer":{
"Code":"05",
"Description":"Rate excludes VAT. Rate includes a fuel surcharge, but excludes taxes, duties and other charges that may apply to the shipment."
},
"Service":{
"Code":"14",
"Description":""
},
"RatedShipmentAlert":[
{
"Code":"120902",
"Description":"Negotiated rates cannot be returned without a valid account number."
},
{
"Code":"110971",
"Description":"Your invoice may vary from the displayed reference rates"
}
],
"BillingWeight":{
"UnitOfMeasurement":{
"Code":"LBS",
"Description":"Pounds"
},
"Weight":"2.0"
},
"TransportationCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"141.84"
},
"ServiceOptionsCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"0.00"
},
"TotalCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"141.84"
},
"GuaranteedDelivery":{
"BusinessDaysInTransit":"1",
"DeliveryByTime":"8:00 A.M."
},
"RatedPackage":{
"TransportationCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"141.84"
},
"ServiceOptionsCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"0.00"
},
"TotalCharges":{
"CurrencyCode":"USD",
"MonetaryValue":"141.84"
},
"Weight":"2.0",
"BillingWeight":{
"UnitOfMeasurement":{
"Code":"LBS",
"Description":"Pounds"
},
"Weight":"2.0"
}
}
}
]
}
}
from magento2.
I have looked into UPS guides further. I have worked out that the setup can go wrong with the information: User ID, Password, Gateway URL and origin setting:
User ID
: I have assigned theClient ID
valuePassword
: I have assigned theClient Secret
valueGateway URL
: I left this to the system value:https://wwwcie.ups.com/api/rating/
- Origin and set up the right address: I have
US, California, 90034
(there is no city, street address defined at the moment)
Could we double check these information settings before we go any further?
#https://amasty.com/knowledge-base/how-to-set-up-ups-in-magento-2.html
#https://www.ups.com/upsdeveloperkit
from magento2.
I have a draft PR in place for this issue. The changes in the PR do resolve the problem but I'd like to check if we can also ensure that the integration can work with the other modes without being restricted to Inches before I finalise the PR
see: #38673
from magento2.
@sanmic in the same way that Inch is hard-coded, I can see the dimensions for the request is also hard-coded. This is just below the place that you had patched:
"Length" => "5",
"Width" => "5",
"Height" => "5"
I have changed the part you recommended us to change but I have not changed the dimensions. Would you be able to comment whether we should change it or not?
from magento2.
@magento run all tests
from magento2.
Related Issues (20)
- Remove Coupon From Cart but not resetting applied_rule_ids on quote item table HOT 10
- Product is still visible in catalog search after setting category permission to only logged in customers in magento2.4.6 HOT 5
- Widget not inserting or saving when the word 'type' is used anywhere in the text after a quotation mark HOT 9
- Products not Showing in Category Pages: 'We can't find products matching the selection' Error HOT 8
- Javascript files for checkout cannot be accessed, wrong src HOT 12
- Sample Data is installed with errors. See log file for details HOT 3
- Vault/Stored Payment Methods not selected value when changing the uncheck/check my billing address and shipping address are the same HOT 9
- getTracking() not found HOT 4
- [Issue] required_options not updating correctly HOT 1
- Require Emails Confirmation behavior issue HOT 3
- UI Listing - Bookmark issue when no filters HOT 7
- Magento 2 api add order comment and change status. HOT 4
- Magento 2 Luma top menu loads very slow HOT 3
- Cannot edit product images from Magento cron HOT 3
- Credis update to 1.6 breaks Magento 2.4.7 HOT 14
- can not update custom customer attribute value on customer edit page in admin HOT 4
- Error "Please correct the target currency" when switching store with different currency than default one on GraphQl HOT 2
- [Issue] Fix dynamic rows dnd array serializer in design config
- Error Cannot return null for non-nullable field "SelectedShippingMethod.carrier_code" HOT 2
- Imposible to reorder configurable products with one checkbox selected custom option HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magento2.