Comments (4)
@amenk
Thank you for the suggested code improvement.
From a developer point of view, exception usage does have advantages over returning an error text. However, implementation seems to be a pretty complex task, which requires modification of all places where Mage_Sales_Model_Quote::addProductAdvanced()
or Mage_Sales_Model_Quote::addProduct()
is used and covering them with appropriate tests.
At the same time, proposed code changes do not bring any value from the business stand point: it's not a new feature (even for a developer), not a bug fix, not a performance improvement.
In order to get a progress on this ticket, it should be supplied with the pull request, which implements proposed changes along with unit/integration tests.
from magento2.
@amenk
We are closing this ticket because of no feedback for more than 2 weeks. If you want to contribute, feel free to submit a new pull request.
from magento2.
I am a bit terrified that you close issues when there was no activity. This is still an issue and should be fixed.
Please reopen.
from magento2.
Hello Amenk, we have really huge backlog of issues that require deep system changes and that we know bring value to developers and business. As someone noted above, this one, while needed, is low priority and requiring many changes. If someone can contribute it - great - but there is very small chance our team will do that. We need to close tickets in github as it is easier to manage them.
from magento2.
Related Issues (20)
- Bug on the product page loading (Catalog>Product) HOT 8
- Attribute option not showing on configurable product detail page HOT 12
- ESI controller generates an issue HOT 10
- AttributeOptionLabelInterfaceFactory not being generated HOT 12
- [Issue] Put division calculations in less files in parentheses if they were not there alr⦠HOT 4
- admin Password update. HOT 15
- [Issue] Update Status model in Sales module HOT 5
- Catalog Import Process Fails to Generate Category URL Rewrites for the multiple Website HOT 9
- [Issue] Removing non RFC3986 authorized characters HOT 3
- Custom import failing when SKU contains double-quote character HOT 17
- When reordering an order placed from admin with a custom price, the cart shows the wrong price of the product. HOT 23
- product gallery without width and height parameters HOT 3
- [Issue] Let background commands actually run in the background HOT 4
- Mandatory fields in admin for Magento_Company do not match the fields on my account page HOT 9
- Admin Sales Grid Bug: Something went wrong with processing the default view and we have restored the filter to its original state. HOT 15
- how to upgrade a magento 2.4.x to 2.4.x(the latest one) through using GITHUB HOT 3
- [Issue] Don't assume a frontend cache section exists in the env.php file. HOT 2
- Fatal error thrown on exception constructor when cookies store is an array HOT 11
- Magento\Quote\Model\GuestCart\GuestCartItemRepository RESTAPI getList masked_id used as filter but cartId is given. HOT 4
- GraphQL Endpoint Error in Developer and Default Modes HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magento2.