Comments (27)
To the left of message id ex. WM_CLOSE there is a letter, one of "S", "P", "R",
their meaning are:
S - the message sent using SendMessage()
P - using PostMessage()
R - denotes return value for SendMessage()
Maybe we should PostMessage to destroy the main window so that we can return
immediately from WM_CLOSE and the order in these messages is correct.
Original comment by [email protected]
on 8 Jul 2012 at 8:41
- Added labels: OpSys-Windows
from cefpython.
Success. In CloseApplication() [cefadvanced.py and cefsimple.py] I've replaced:
> cefwindow.DestroyWindow(windowID)
with:
> win32api.PostMessage(windowID, win32con.WM_DESTROY, 0, 0)
And now order of messages in Spy++ is correct, "S WM_CLOSE", "R WM_CLOSE", "R
WM_SYSCOMMAND" and the last "P WM_DESTROY".
In WM_CLOSE and WM_DESTROY procedures "return 0" statement can be omitted.
If I put "return win32gui.DefWindowProc()" after PostMessage() then the order
of messages in Spy++ is wrong again, so don't do it.
I've been clicking and closing windows for a few minutes and it seems that
everything works fine now. I will be testing it for the next few days, if there
are no errors on exit then I will close this issue.
Original comment by [email protected]
on 8 Jul 2012 at 9:12
from cefpython.
[deleted comment]
from cefpython.
[deleted comment]
from cefpython.
Original comment by [email protected]
on 12 Jul 2012 at 10:39
- Changed state: Fixed
from cefpython.
This issue is still not properly fixed, errors of "memory cannot be read" when
closing browser are still appearing on windows 2003.
Original comment by [email protected]
on 21 Aug 2012 at 12:20
- Changed state: Accepted
- Added labels: Priority-Critical
- Removed labels: Priority-Medium
from cefpython.
Issue in CEF has been reported:
http://code.google.com/p/chromiumembedded/issues/detail?id=700
Original comment by [email protected]
on 22 Aug 2012 at 6:30
from cefpython.
This issue still persists in XP.
Original comment by [email protected]
on 24 Aug 2012 at 4:16
from cefpython.
In issue 700 on CEF:
http://code.google.com/p/chromiumembedded/issues/detail?id=700
Marshall has provided a solution. But to test it I will have to compile
Chromium sources + CEF sources and build my own binaries, it can take time as
it's probably not an easy task.
Original comment by [email protected]
on 24 Aug 2012 at 5:03
from cefpython.
@alex.nanou:
In the meantime there is a solution, it's not perfect as CEF won't do cleanup
after itself (scoped_dir/ in temp/) but it should get rid of error.
In QuitApplication() replace "win32gui.PostQuitMessage(0)" with this line:
os.kill(os.getpid(), 9)
(one might also try sys.exit(0) or os._exit(0) - which are less drastic)
Original comment by [email protected]
on 24 Aug 2012 at 5:21
from cefpython.
Update to temporary solution.
In QuitApplication() replace "win32gui.PostQuitMessage(0)" with this lines:
cefpython.Shutdown()
os.kill(os.getpid(), 9)
Original comment by [email protected]
on 24 Aug 2012 at 6:34
from cefpython.
It would be be even better to put os.kill after the loop and shutdown, without
modifying QuitApplication(), but I'm not sure whether it would fix the error,
but worth checking. In CefAdvanced() add os.kill after MessageLoop() and
Shutdown():
cefpython.MessageLoop()
cefpython.Shutdown()
os.kill(os.getpid(), 9)
Alex can you confirm that this fixes the error?
Original comment by [email protected]
on 24 Aug 2012 at 6:44
from cefpython.
At this point it's not critical, for me at least, the software I'm working on
is not yet public and will not be out for several weeks... so I'm not digging
in this particular issue yet.
BTW, neither workaround seems to work.
Original comment by [email protected]
on 25 Aug 2012 at 9:13
from cefpython.
I have a report from other user that os.kill() called after shutdown fixes the
error. Please describe your error in more details as this seems like some other
bug. Try putting os.kill in one of 3 places: in CloseApplication(), in
QuitApplication(), after Shutdown() - one of them must fix the problem.
Original comment by [email protected]
on 25 Aug 2012 at 9:24
from cefpython.
Are you using latest 0.35 version?
Original comment by [email protected]
on 25 Aug 2012 at 10:19
from cefpython.
version 0.35, as before.
kill after Shutdown works.
Original comment by [email protected]
on 26 Aug 2012 at 5:32
from cefpython.
Putting os.kill after Shutdown() is the best place for it.
Use this solution until this issue is fixed.
Original comment by [email protected]
on 26 Aug 2012 at 5:59
from cefpython.
[deleted comment]
from cefpython.
I am unable to compile Chromium on WinXP, from what I read building chrome on
XP is not supported anymore, command line arguments passed to compiler are too
long and builds fail. I am going to need Win7 and a new hdd to build it.
Original comment by [email protected]
on 1 Sep 2012 at 7:39
from cefpython.
I've successfully compiled Chromium, branch 1025 revision 607.
I've created 2 zip binaries to test.
1. Issue 2 test 1:
First we need to test whether to bug still persits, so use "test 1" to confirm
the bug, app should crash when closing window while running this test.
http://code.google.com/p/cefpython/downloads/detail?name=issue2_test1_0.38_py27.
zip&can=2&q=#makechanges
2. Issue 2 test 2:
This binaries have the Marshall's patch applied, this should fix the crash when
closing app.
http://code.google.com/p/cefpython/downloads/detail?name=issue2_test2_0.38_py27.
zip&can=2&q=#makechanges
Alex, let me know whether this fixes the problem.
Original comment by [email protected]
on 3 Sep 2012 at 9:45
from cefpython.
Have a report from Cjjer that test2 still didn't fix the error. Will report
that to Marshall, we will have to wait for some other fix.
Original comment by [email protected]
on 3 Sep 2012 at 9:56
from cefpython.
i am cjjer.
windows2003 sp2,all test has the error.
Original comment by [email protected]
on 3 Sep 2012 at 9:57
Attachments:
from cefpython.
With big help of Cjjer, after many hours of testing we have this error fixed,
I've made some minor modifications to the fix so it still needs some testing,
here is the final test:
Test 6 should resolve this issue:
http://code.google.com/p/cefpython/downloads/detail?name=issue2_test6_0.38_py27.
zip
Original comment by [email protected]
on 3 Sep 2012 at 3:19
from cefpython.
This issue is related to our problem:
"CEF1: Eliminate use of scoped directories"
http://code.google.com/p/chromiumembedded/issues/detail?id=670
Original comment by [email protected]
on 3 Sep 2012 at 9:46
from cefpython.
Cjjer confirmed that test 6 fixes the error. This fix will make it into next
release.
Original comment by [email protected]
on 4 Sep 2012 at 6:44
- Changed state: Fixed
from cefpython.
Version 0.38 released.
Original comment by [email protected]
on 4 Sep 2012 at 9:18
from cefpython.
This bug has been fixed in CEF sources in revision `827`:
http://code.google.com/p/chromiumembedded/source/detail?r=827
Original comment by [email protected]
on 21 Nov 2012 at 6:02
from cefpython.
Related Issues (20)
- The default en-US locale pak file fails to load on Mac HOT 3
- Examples crash on Mac when app doesn't have permission to write to the debug.log file
- Issues with size_t => int conversions when using cef_values.h API on Win x64 platform HOT 2
- Python Wheels - DESCRIPTION.rst UNKNOWN
- Embed __version__ also in the cython generated module (cefpython_py27.pyd) HOT 1
- Create unified key mappings for all platforms HOT 8
- Add Browser.IsDevTools() HOT 1
- Expose CreateBrowser() with a callback argument that will be executed after browser was created
- The popup window and parent window can't script each other in the wxpython.py example HOT 3
- Create "chrome31" branch before updating to a newer CEF branch HOT 1
- wxpython-response.py example: final url is wrong when doing redirects HOT 7
- Close the browser BEFORE the page is full loaded CEF Crashe HOT 1
- Warnings on OS X: Internals of CFAllocator not known HOT 1
- [meta] Migrate the repository somewhere HOT 2
- Gtk: gtk_disable_setlocale() must be called before gtk_init() HOT 2
- Restructure directories (binaries, installer, libraries) to allow for git branching HOT 1
- Automating navigation HOT 1
- Google Code is dying
- Update to CEF branch 2171 (Chrome 39) HOT 1
- Ability to pass modifiers to SendMouseMoveEvent and similar
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cefpython.