Giter Site home page Giter Site logo

Comments (4)

qinghezeng avatar qinghezeng commented on August 17, 2024 3

Thank you so much for your detailed explanation!!

from clam.

fedshyvana avatar fedshyvana commented on August 17, 2024 1

Hi, yes, it's would not be enabled as long as you don't use --subtyping.

from clam.

qinghezeng avatar qinghezeng commented on August 17, 2024

Thank you for your answer!
There is one more thing confusing me. For sub-typing problem, for example, in main.py line 174:

    if args.model_type == 'clam':
        assert args.subtyping

Does it mean the --subtyping flag must be used? However, in line 95:

parser.add_argument('--model_type', type=str, choices=['clam_sb', 'clam_mb', 'mil'], default='clam_sb', 
                    help='type of model (default: clam_sb, clam w/ single attention branch)')

We can see 'clam' option is not accepted for --model_type. So why do we need this?

from clam.

fedshyvana avatar fedshyvana commented on August 17, 2024

Hi, sorry for the confusion, first of all: the assertion statement is just for my own book-keeping i.e. i wanted to use subtyping for that specific task I defined and wanted to make sure that when I was training with that task, i would not forget to enable it. So no, you do not have to use the subtyping flag for any specific task depending on your needs. second of all: 'clam' is just something i forgot to update in the code ('clam_sb' and 'clam_mb' used to be a single option called 'clam') - i will correct that shortly, thanks for pointing out.

from clam.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.