Giter Site home page Giter Site logo

Comments (6)

fedshyvana avatar fedshyvana commented on August 17, 2024

Hi Quincy, I do not believe there to be any issue with the code itself. I looked at TCGA-DA-A95X-01Z-00-DX1.F66442E6-F0C9-4528-B000-E47FCAA964FD, the tissue regions are small within the slide, so it's likely that its simply filtered out as artifacts under the default segmentation parameters. You can check the segmentation mask under "masks" to verify if this is the case. If you have slides like this in your dataset, you should set a smaller default "a_t" and "a_h" values or simply tweek the parameters for the select slides that are not segmented correctly (see README for more details on what the parameters do and how to adjust them).

from clam.

fedshyvana avatar fedshyvana commented on August 17, 2024

TCGA-DA-A95X-01Z-00-DX1 F66442E6-F0C9-4528-B000-E47FCAA964FD
Here's the stitched result for setting a_h and a_t as 1 for example.

from clam.

quincy-125 avatar quincy-125 commented on August 17, 2024

Thanks for your quick response, that means we need to manually tweek the threshold, does this is the point you mean to say? If it is, I'm wondering to know if I have a large dataset, that means I have to manually adjust the threshold for samples like what I provided to you. Correct me if I'm wrong. Thanks so much!

from clam.

fedshyvana avatar fedshyvana commented on August 17, 2024

Yes, you can't go wrong with manually checking and changing parameters for select slides, but you can also define your own set of default segmentation values, and pass it to the "--preset" flag. For example, I think if you know that not every slide in your dataset contains large resected tissue, and instead you have biopsies and slides with small tissue fragments, I would just set define a preset with smaller a_t and a_h values. e.g. you can just take the tcga.csv preset file, and set a_t and a_h to be smaller (e.g. less < 10), and use that as your default values.

from clam.

quincy-125 avatar quincy-125 commented on August 17, 2024

sure, that makes sense to me. I actually re-implemented your code in tensorflow, that's why I want to test your code just to make sure I got your logic of this model correctly. not sure you would like to help and see if my re-implemented version is the same as your idea? If it is, you could leave your email in below, I'll reach out to you offline.

Anyway, thanks for your response again. you could close this issue now. Highly appreciated.

from clam.

fedshyvana avatar fedshyvana commented on August 17, 2024

Sure my email is [email protected]. I am however not confident that I would be able to contribute much since I'm not familiar with Tensorflow syntax.

from clam.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.