Giter Site home page Giter Site logo

Comments (7)

aedocw avatar aedocw commented on May 27, 2024 3

I'm not speaking for @MahmoudAshraf97 here, but if you take a look at his response from Jan 24, it's pretty clear. This is an open source project that he's doing for whatever his reasons are. @utility-aagrawal, you are treating it like a commercial product that you are paying for.

If you want these changes, you are free to implement them and submit the PR's to get them merged into the project. If you are not a developer, you could pay someone to do the work and submit the patches.

from whisper-diarization.

MahmoudAshraf97 avatar MahmoudAshraf97 commented on May 27, 2024 1

Hello and thanks for the input، please open a PR with any changes you see that are useful and we can discuss them together

from whisper-diarization.

utility-aagrawal avatar utility-aagrawal commented on May 27, 2024

@MahmoudAshraf97 , will appreciate your take on this! Thanks for sharing your work!

from whisper-diarization.

utility-aagrawal avatar utility-aagrawal commented on May 27, 2024

@MahmoudAshraf97 , Thanks for your understanding! This is what I want to do:

  1. Leave existing functionalities as-is.

  2. Please see the attached .txt file. Currently, a lot of messages/warnings/logs are displayed in command line, I want to make this optional where users can choose if they want to see these messages.
    whisper_diarization_stdout.txt

  3. If users want, they should be able to run the whole pipeline locally. Meaning that they can download all the models in a directory beforehand. Faster-whisper and whisperX load_align_model already have support for this. I can check if other models can also be used in this way. Do you know if this is feasible? What other models are used in this pipeline? I still have to go through the code and don't have this answer yet.

  4. Format the code for readability and usability.

Let me know what you think. It will take some time to make all these changes. Before I spend any time, I wanted to align with you. Thanks!

from whisper-diarization.

utility-aagrawal avatar utility-aagrawal commented on May 27, 2024

@MahmoudAshraf97 , do you have any feedback?

from whisper-diarization.

utility-aagrawal avatar utility-aagrawal commented on May 27, 2024

@MahmoudAshraf97 , thought?

from whisper-diarization.

transcriptionstream avatar transcriptionstream commented on May 27, 2024

I have this running in a production environment - it’s stable, consistent, and does a great job

from whisper-diarization.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.