Any interest in merging concerns?

[mailgun]

Any interest in merging concerns?

[travelton]

Hi Chris -

At a high level, our code bases accomplish the same goals. However, at a lower level, the implementations are quite different.

There may be pieces of code or design patterns that could be ported to Mailgun's code base. I don't see any documentation for usage, so I'm not sure about the design patterns. I do see you're relying solely on Curl, where Mailgun relies on Guzzle, an library around Curl. We plan to eliminate the Guzzle requirement in version 2.

Could you point me to code that you feel could enhance the library. Or if you're comfortable submitting a pull request, that would be great as well.

Thanks,
Travis

[chriswoodford]

Hey Travis,

Initially I just wanted to touch base and see if it was something that you'd even be interested in, before doing any work for a pull request.

As far as design patterns, I'm using the Gateway pattern (PoEAA) as a higher level wrapper for sending email messages. If you're interested in replacing Guzzle for Curl, my library relies on an HttpClient interface, which could be something to help ease that transition (i.e. use a Guzzle Adapter that conforms to the HttpClient interface and then update the mailgun code to rely on the HttpClient interface). Then flipping to a straight Curl Adapter would be pretty easy. My code is currently using an Adapter for the Buzz library which is a lightweight wrapper around Curl (https://github.com/kriswallsmith/Buzz)

If you're interested, I could definitely sketch out a pull request for you to review. Let me know what you think

thanks,
Chris

[Nyholm]

Im closing this issue because of inactivity and because it has been a lots of rewrites of the design in the last year.
Feel free to open a new issue with some comments. I would be happy to discuss the current state.