Comments (3)
Hi Chris -
At a high level, our code bases accomplish the same goals. However, at a lower level, the implementations are quite different.
There may be pieces of code or design patterns that could be ported to Mailgun's code base. I don't see any documentation for usage, so I'm not sure about the design patterns. I do see you're relying solely on Curl, where Mailgun relies on Guzzle, an library around Curl. We plan to eliminate the Guzzle requirement in version 2.
Could you point me to code that you feel could enhance the library. Or if you're comfortable submitting a pull request, that would be great as well.
Thanks,
Travis
from mailgun-php.
Hey Travis,
Initially I just wanted to touch base and see if it was something that you'd even be interested in, before doing any work for a pull request.
As far as design patterns, I'm using the Gateway pattern (PoEAA) as a higher level wrapper for sending email messages. If you're interested in replacing Guzzle for Curl, my library relies on an HttpClient interface, which could be something to help ease that transition (i.e. use a Guzzle Adapter that conforms to the HttpClient interface and then update the mailgun code to rely on the HttpClient interface). Then flipping to a straight Curl Adapter would be pretty easy. My code is currently using an Adapter for the Buzz library which is a lightweight wrapper around Curl (https://github.com/kriswallsmith/Buzz)
If you're interested, I could definitely sketch out a pull request for you to review. Let me know what you think
thanks,
Chris
from mailgun-php.
Im closing this issue because of inactivity and because it has been a lots of rewrites of the design in the last year.
Feel free to open a new issue with some comments. I would be happy to discuss the current state.
from mailgun-php.
Related Issues (20)
- Fatal error: Uncaught TypeError: Mailgun\Api\Domain::index() HOT 2
- Improvement: SDK version headers v2 vs v3 HOT 1
- Oudated symfony/http version HOT 3
- Bounces: The endpoint you have tried to access does not exist. HOT 2
- PHPDoc Type issue in Mailgun\Api\MailingList\Member HOT 2
- Get all lists
- TypeError: Mailgun\Api\Suppression\Bounce::show() HOT 1
- Bug: Proper json_last_error() handling with try catch
- Errors after latest update regarding json syntax HOT 2
- Error (4) when trying to json_decode response HOT 1
- Suppressions -> Bounces: cannot show for a specific address HOT 5
- Clarify effects of using php-http/discovery
- Returned data with send? HOT 1
- BCC not working properly when batch sending HOT 10
- Endpoint not correct for Tag > stats() HOT 1
- How to mock Mailgun?
- Get message from EU server?
- Feature Request: Add dkim_host_name and dkim_selector options to domains()->create() method HOT 2
- The template search filters do not match the documentation. HOT 1
- php mailgun not work with php version 8.3 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mailgun-php.