Giter Site home page Giter Site logo

Comments (4)

obukhov-sergey avatar obukhov-sergey commented on July 28, 2024

This is actually by design. Most signature lines are less than 60 chars. So it's a good sanity check. 80 chars is definitely too much - you'll get a lot of false positives. We could uplift it of course a bit e.g. to 65 but there will always be an email with + 1 char. 60 chars seems like a reasonable number.

from talon.

davidlehn avatar davidlehn commented on July 28, 2024

Understood. Looking at some of my mail, many sigs are just basic name, org, url, etc. But lots of mailing lists have signature-like footers with longer list info URLs. And there are the people that send mail with huge blobs of legalese signatures which certainly go over 60 char lines. Feel free to close but maybe add some notes to the docs about the issue.

from talon.

obukhov-sergey avatar obukhov-sergey commented on July 28, 2024

Sure. I think the best solution will be to parse those specific signatures separately prior to detecting "human" signature. The legalese signatures are quite different from "human" signatures and require different detection techniques.

I'm actually thinking about a separate module and maybe a different name for those cases e.g. something like "disclaimer".

from talon.

obukhov-sergey avatar obukhov-sergey commented on July 28, 2024

I've created a separate issue for disclaimers #8. Going to close this one. Thanks for your feedback!

from talon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.