Giter Site home page Giter Site logo

Add support for Python 3.4 about talon HOT 15 OPEN

mailgun avatar mailgun commented on July 28, 2024 4
Add support for Python 3.4

from talon.

Comments (15)

Sumeet-Jain avatar Sumeet-Jain commented on July 28, 2024 7

Hi,
I started to port this to python3.4.3. I have a fork where it passes almost all tests. However, it isn't backwards compatible with 2.7 (the project that I need talon for only uses python3). Feel free to check it out. In the next few weeks, I'll try to make it backwards compatible.

from talon.

longedok avatar longedok commented on July 28, 2024

+1

from talon.

tahseen avatar tahseen commented on July 28, 2024

Python 3 support will be great.

from talon.

ddemid avatar ddemid commented on July 28, 2024

+1

from talon.

maccman avatar maccman commented on July 28, 2024

+1

from talon.

ad-m avatar ad-m commented on July 28, 2024

👍

I am would like mark mailgun/talon require mailgun/flanker (lack python3 support) which require mailgun/expiringdict, which lack of python 3 support too.

from talon.

tgwizard avatar tgwizard commented on July 28, 2024

Hi,

I've created a fork of talon, https://github.com/tictail/claw, in which I've removed the signature extraction that depends on ML (which I didn't use), and cleaned up some dependencies (now much less weird stuff installed). I've also started to implement some bug fixes, along with CI test suites and so on.

Flanker is only used in the tests, so to get Python3.4 support working would be to just find another way to run those tests.

from talon.

obukhov-sergey avatar obukhov-sergey commented on July 28, 2024

Hi all. Talon has been updated to have no flanker dependency. Could you please check compatibility with Python 3.4?

from talon.

ad-m avatar ad-m commented on July 28, 2024

@obukhov-sergey , talon still require "lxml==2.3.3", but lxml < 3, are not python 3 compatible.

from talon.

ad-m avatar ad-m commented on July 28, 2024

@obukhov-sergey , At https://github.com/ad-m/claw/tree/mailgun_talon I created fork of your repo, added TravisCi by python 2.7,3.3 and 3.4.

In .travis.yml I used conda package manager, due some performance issues (which make installations fails on Travis) for numpy, scipy and scikit-learn. Now it install fast enought.

Unfortuanetly, syntax of talon aren't python3 compatible. See for your code: https://travis-ci.org/ad-m/claw/jobs/79189172 .

I tried use 2to3 over talon code, but it still fails (see https://travis-ci.org/ad-m/claw/jobs/79186653 ).

from talon.

obukhov-sergey avatar obukhov-sergey commented on July 28, 2024

Hi @ad-m, thanks. I've unpinned lxml version. Will try to address other comments as soon as possible but no ETA.

from talon.

ad-m avatar ad-m commented on July 28, 2024

@obukhov-sergey , you have to add cssselect to dependencies too.

from talon.

ad-m avatar ad-m commented on July 28, 2024

@Sumeet-Jain , thank you.

from talon.

timabbott avatar timabbott commented on July 28, 2024

#97 does the work to make the parts of talon that don't use ML support Python 3.

from talon.

yfilali avatar yfilali commented on July 28, 2024

Since this is still unsolved, I have a python 3 version of talon ready to go. All tests are passing from python 2.7 to python 3.6 although I had to modify some of the tests to assert against byte arrays instead of string, and to pass an encoding when opening unicode files on python 3.

I'll send in a PR shortly.

from talon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.