The mailjet gem should not be setting ActiveSupport.parse_json_times = true

[mailjet]

The mailjet gem should not be setting ActiveSupport.parse_json_times = true

[tbuyle]

Hi,

This actually cause an error in an application i am working on.

The application use FineUploader (http://fineuploader.com) to send file to amazon S3. Using the mailjet gem caused the S3 upload to fail due to invalid expiration date format...

Setting ActiveSupport.parse_json_times = false in app initializer does solve the issue... But I suppose it would actually be needed to use the mailjet API through the gem.

[bradleypriest]

ping @tylernappy @jbescoyez

[tylernappy]

Hi,

I apologize for a late response on this. I'm currently looking into this and will get back to you soon.

[tbuyle]

As I only need to use Mailjet for SMTP, this is not an urgent issue for me.

But it would certainly be better to change this.

[tbuyle]

Sorry to be nitpicking but shouldn't the line "ActiveSupport.parse_json_times = ... " be completely removed ?

Here we are still setting a global application config by default.

Wouldn't it be better to leave the application config as it is and, if necessary, set a new variable for the library to use ?

[bradleypriest]

Yeah, this is not solved at all.
Firstly, the whole point was to remove the global config,
Secondly, how the hell did the whole test suite not fail by changing such a core toggle.
I'm seriously worried about the technical abilities of my mail provider right now

[bradleypriest]

I'm not sure why I can't reopen, can you guys please do it from your end

[tylernappy]

Hi,

Sorry for the premature issue closing :/

We are working on a solution to this issue that will be implemented shortly.

[tylernappy]

Hi,

In our most recent update, we have taken out the option that globally changes the date output from JSON. Now, only dates output from our API will be parsed, leaving JSON dates from other sources unaffected.