Giter Site home page Giter Site logo

Comments (4)

BillyRayPreachersSon avatar BillyRayPreachersSon commented on September 28, 2024 1

As with the comment against the same issue for ember-simple-auth, would you be able to publish a new major version without the polyfill that supports only Ember 2.4+, thus negating the issue of backwards compatibility for those using the new version?

from ember-cookies.

marcoow avatar marcoow commented on September 28, 2024

I think we already allow the latest version of ember-getowner-polyfill? see https://github.com/simplabs/ember-cookies/blob/master/package.json#L24

from ember-cookies.

BillyRayPreachersSon avatar BillyRayPreachersSon commented on September 28, 2024

Out of interest, what version is the minimum version of Ember this addon is trying to support? If it's Ember 2.4, then the ember-getowner-polyfill reference can be removed altogether and this warning will go away.

We've managed to get from 29 of these deprecation warnings down to 7, and 3 of those are from simplabs addons (ember-simple-auth and ember-cookies). It would be lovely to have no warnings :)

from ember-cookies.

marcoow avatar marcoow commented on September 28, 2024

We're supporting Ember 1.13 and up and thus needs the polyfill unfortunately.

from ember-cookies.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.