Can't index a property value by its type when using Typescript

[makenotion]

Can't index a property value by its type when using Typescript

[blackmad]

Okay I understand now what you're trying to do. Let me consult the typescript sages.

…

On Thu, May 27, 2021 at 12:34 PM Dane Grant ***@***.***> wrote: I'm pretty new to typescript but I don't understand why this shouldn't work either. If the related key in the block is always the same name as the type, I should be able to access it with a key. I get that TypeScript doesn't know that but is there not a simple way to handle this? [image: Screen Shot 2021-05-27 at 12 30 55 PM] <https://user-images.githubusercontent.com/3721977/119863515-a337d480-bee7-11eb-9b84-a160169215c4.png> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#92 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADMZMHELYCRY4MYTUPPCF3TPZX7VANCNFSM45KTSVLQ> .

[blackmad]

Hey Rian -

I'm not sure what you're describing would achieve the type safety we're aiming for in the library, since your function would return a bunch of property data that can no longer be type-discriminated.

You can see an example of how we imagine this being used in a type-safe way at https://github.com/makenotion/notion-sdk-js/blob/main/examples/generate-random-data/index.ts

I'm open to other suggestions!

[danecando]

I'm pretty new to TypeScript but I don't understand why this shouldn't work either. If the related key in the block is always the same name as the type, seems like I should be able to access it using the key. I get that TypeScript doesn't know that but is there not a simple way to handle this? My first instinct is that it's an issue with the structure of the objects; that they should use a common prop name to store the data.

(clearly im still in the why can't we just use js phase of my ts journey) :)

[EnixCoda]

I had similar issues using this SDK. And attempted to solve with TS type prediction in PR #115

@RianGallagher Would you take a look at the PR and let me know your thoughts from the aspect of an user? Thank you :D