`limits!` hangs when being passed a an indexed Figure, not an Axis

[vandenman]

`limits!` hangs when being passed a an indexed Figure, not an Axis

[Sagnac]

I've opened a PR with the fix. My initial solution wasn't ideal since it didn't allow for the lims to have a value of nothing so now there's an additional check on the current axis.

[Sagnac]

Looks like this method is being called in a loop:

Makie.jl/src/makielayout/blocks/axis.jl

Lines 1375 to 1377 in 5c8d07c

	function limits!(args...)
	limits!(current_axis(), args...)
	end

Placing a suitable restriction on args seems to do the trick:

diff --git a/src/makielayout/blocks/axis.jl b/src/makielayout/blocks/axis.jl
index 8248577fb..3d270b73a 100644
--- a/src/makielayout/blocks/axis.jl
+++ b/src/makielayout/blocks/axis.jl
@@ -1372,7 +1372,7 @@ function limits!(ax::Axis, rect::Rect2)
     Makie.ylims!(ax, ymin, ymax)
 end
 
-function limits!(args...)
+function limits!(args::Union{Real, HyperRectangle}...)
     limits!(current_axis(), args...)
 end
 

[vandenman]

@Sagnac That line indeed looks like the source of the problem and the proposed fix looks like it will solve it. Will you commit a fix or do you prefer if I open a PR?

[Sagnac]

I can prepare a PR later today or tomorrow