Undelete does nothing when using DELETED_INVISIBLE

[makinacorpus]

Undelete does nothing when using DELETED_INVISIBLE

[Gagaro]

The easiest way would be to add _do_update to the SafeDeleteMixin and just call super with a different base_qs. I won't have time to test this until tuesday though.

[Gagaro]

Also, we should add a test to ensure this is solved on every version.

[Gagaro]

I did some tests and the _base_manager is actually the Django one. And these tests should fail if there is a problem. Do you overwrite the _base_manager manually on your models?

https://github.com/makinacorpus/django-safedelete/blob/master/safedelete/tests.py#L148-L169

[sbussetti]

I'll do a little more research and commit some tests that demonstrate the issue. I actually have to override _base_manager to set it back to models.Manager.

[rromanchuk]

Hey guys quick question, documentation says DELETED_INVISIBLE is the default, yet i'm still able to retrieve a soft deleted object, am i missing something here?

>>> user = User.users.get(pk=user.guid)
>>> user.deleted
True

[Gagaro]

Hi @rromanchuk, what version are you using and how is your model configured?

It works fine with the 3.2 and the default SoftDeleteMixin:

>>> User.objects.create(name='toto')
<User: User object>
>>> User.objects.get()
<User: User object>
>>> User.objects.get().pk
1
>>> a = User.objects.get()
>>> a.delete()
>>> a.deleted
True
>>> User.objects.all()
[]
>>> User.objects.get(pk=1)
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/home/gagaro/.virtualenvs/django1.8-python3.4/lib/python3.4/site-packages/safedelete/managers.py", line 72, in get
    return self.get_queryset().get(*args, **kwargs)
  File "/home/gagaro/.virtualenvs/django1.8-python3.4/lib/python3.4/site-packages/django/db/models/query.py", line 334, in get
    self.model._meta.object_name
models_test.models.DoesNotExist: User matching query does not exist.
>>> User.objects.get(pk=1)

[rromanchuk]

@Gagaro it's probably just user error, let me try again with fresh eyes. Here is what I have though.

my_mixin = safedelete_mixin_factory(policy=SOFT_DELETE)
class User(my_mixin):

with requirements.txt
django-safedelete==0.3.2

[Gagaro]

Hi @rromanchuk, do you still have the problem?

[Gagaro]

Reopen this issue if you have more info/can reproduce in tests.