Giter Site home page Giter Site logo

Comments (2)

Gagaro avatar Gagaro commented on August 17, 2024

You need to set the custom queryset and the manager on the same model. I added your PR corrected on master:

https://github.com/makinacorpus/django-safedelete/blob/master/safedelete/tests.py#L52-L66

Because the base manager inherit from the class you pass to the factory, your get_queryset method is actually overridden (https://github.com/makinacorpus/django-safedelete/blob/master/safedelete/managers.py#L41).

This is kind of counter intuitive, this is one of the reason why I wanted to remove the factory. You can take a look at the 0.4.x branch (https://github.com/makinacorpus/django-safedelete/tree/0.4.x) in which I removed them. I still want to do some things before release (#43), but it should be fairly stable.

from django-safedelete.

smcoll avatar smcoll commented on August 17, 2024

@Gagaro much appreciated.

from django-safedelete.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.