Trying to get ValuesListQuerySet throws "TypeError: _clone() takes exactly 1 argument (2 given)"

[makinacorpus]

Trying to get ValuesListQuerySet throws "TypeError: _clone() takes exactly 1 argument (2 given)"

[jkkjonah]

Test that reproduces the issue w/ Django 1.8.*: #92

[Gagaro]

2fd3a5f#commitcomment-27160176

I took a stab a this. I have no clue why this happed. I read the Django code base. Seems like QuerySet takes self, flat and *kwargs as arguments. No clue why this happens: https://github.com/django/django/blob/1.8.18/django/db/models/query.py#L1144

This is what we have for 1.11: https://github.com/django/django/blob/1.11.9/django/db/models/query.py#L1106

And the traceback:

Traceback (most recent call last):
  File "/home/travis/build/makinacorpus/django-safedelete/safedelete/tests/test_queryset.py", line 202, in test_values_list
    QuerySetModel.objects.filter(id=instance.id).values_list('pk', flat=True)[0]
  File "/home/travis/build/makinacorpus/django-safedelete/safedelete/queryset.py", line 121, in __getitem__
    return super(SafeDeleteQueryset, self).__getitem__(key)
  File "/home/travis/build/makinacorpus/django-safedelete/django/django/db/models/query.py", line 199, in __getitem__
    qs = self._clone()
  File "/home/travis/build/makinacorpus/django-safedelete/django/django/db/models/query.py", line 1244, in _clone
    clone = super(ValuesListQuerySet, self)._clone(*args, **kwargs)
  File "/home/travis/build/makinacorpus/django-safedelete/django/django/db/models/query.py", line 1144, in _clone
    c = super(ValuesQuerySet, self)._clone(klass, **kwargs)
TypeError: _clone() takes 1 positional argument but 2 were given

[Gagaro]

Our implementation is incorrect, we overwrite the _clone method:

https://github.com/makinacorpus/django-safedelete/blob/master/safedelete/queryset.py#L139-L147

[Gagaro]

Fixed in ab96e7b, thanks everyone for the help.

[Gagaro]

0.4.5 has been released with the fix