Giter Site home page Giter Site logo

Comments (5)

makuto avatar makuto commented on August 19, 2024

I tried a similar background (I couldn't find the exact one you used) and got these results:
image
Could you send me the exact wallpaper so I can try it? I suspect it's a problem with how Terminator is using the Base16 colors, but just to be sure, I can dig deeper on my script.

from auto-base16-theme.

Fodark avatar Fodark commented on August 19, 2024

Here you are, thanks!

Background

from auto-base16-theme.

makuto avatar makuto commented on August 19, 2024

Sorry for the wait!

I tried it with that wallpaper and got fine results. I suspect it is how Terminator uses the base16 colors. If you can, edit your outputted terminator config and find which base16 color (should be equal to #000000) it's using for the unreadable text (change it to another color). If you tell me e.g. base08 then I could add the contrast constraints to that color for your specific setup.

from auto-base16-theme.

Fodark avatar Fodark commented on August 19, 2024

Thanks for the reply!

The color of the text is not completely black, but #1C070Cand it's the color in the second position in the config (base01 maybe?).
I noticed that this #1C070C is not generated by schemer2, is it normal?

from auto-base16-theme.

makuto avatar makuto commented on August 19, 2024

AutoBase16Theme.py has code in it which will make background colors darker so that they're never too bright compared to the base00 color. That's why the color is different from the schemer2 output.

In the Base16 style guide it says that base01 is supposed to be a lighter background for status bars, not text. This means that Terminator isn't looking at the correct colors according to the base16 standard. You have two options to fix this:

  1. Make AutoBase16Theme.py treat base01 as a text color, despite not meeting the standard (other apps will look different, if you use them with the same theme). You can do this by changing this line from pickDarkestColorForceDarkThreshold to pickHighContrastBrightColorUniqueOrRandom
  2. Make Terminator look at the correct base16 value. If I were to guess I would think it should use base05, which is the default foreground. If you used someone else's plugin or something to add Base16 support, you might want to open an issue on their project saying it's not looking at the correct colors.

from auto-base16-theme.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.